Skip to content

Conversation

@RyanCavanaugh
Copy link
Member

Installing -g hereby was messing with package.json and isn't needed. Clarify some instructions to emphasize the need for format since it keeps missing that.

Copilot AI review requested due to automatic review settings June 24, 2025 17:29
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 24, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 24, 2025
@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jun 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the global installation of the hereby CLI, switches all calls to npx hereby, and adds guidance to always lint and format before finishing.

  • Remove npm install -g hereby from CI steps
  • Update documentation to use npx hereby for all build tasks
  • Add “Keeping Things Tidy” section to emphasize running lint and format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/copilot-setup-steps.yml Removed global hereby install and rely on npx hereby in CI
.github/copilot-instructions.md Switched all examples to npx hereby, restructured task listing, and added lint/format tips
Comments suppressed due to low confidence (1)

.github/copilot-instructions.md:275

  • This line uses -- instead of a markdown list bullet. Change it to - Always run hereby lintandhereby format before you're done for consistent formatting.
- A full test run may take up to 15 minutes

@RyanCavanaugh RyanCavanaugh merged commit 6dea899 into microsoft:main Jun 24, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 24, 2025
@RyanCavanaugh RyanCavanaugh deleted the fixCopilotMore branch June 24, 2025 17:44
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants