-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Add copilot-instructions.md #61896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add copilot-instructions.md #61896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new contributor guideline file for Copilot workflows, detailing linting, formatting, test paths, and commit structuring.
- Introduces
.github/copilot-instructions.mdwith step-by-step bug-fix and test-baseline procedures - Specifies commands (
hereby lint,hereby format) and expected test duration - Clarifies where to add test cases and how to organize commits for baselines
Comments suppressed due to low confidence (2)
.github/copilot-instructions.md:10
- [nitpick] This sentence is missing a connector. Consider: "Add the test and its baselines in one commit" to improve clarity.
* Make a testcase that demonstrates the behavior. Run it (by itself) and review the baselines it generates to ensure it demonstrates the bug. Add the test its baselines in one commit
.github/copilot-instructions.md:3
- The path
test/cases/compilerseems inconsistent withtests/cases/fourslash. Consider usingtests/cases/compilerto match the existing folder structure.
* Only add testcases in `test/cases/compiler` or `tests/cases/fourslash`. Do not write direct unit tests.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RyanCavanaugh
commented
Jun 18, 2025
RyanCavanaugh
commented
Jun 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖