Skip to content

Conversation

@RyanCavanaugh
Copy link
Member

🤖

Copilot AI review requested due to automatic review settings June 18, 2025 18:22
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 18, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new contributor guideline file for Copilot workflows, detailing linting, formatting, test paths, and commit structuring.

  • Introduces .github/copilot-instructions.md with step-by-step bug-fix and test-baseline procedures
  • Specifies commands (hereby lint, hereby format) and expected test duration
  • Clarifies where to add test cases and how to organize commits for baselines
Comments suppressed due to low confidence (2)

.github/copilot-instructions.md:10

  • [nitpick] This sentence is missing a connector. Consider: "Add the test and its baselines in one commit" to improve clarity.
 * Make a testcase that demonstrates the behavior. Run it (by itself) and review the baselines it generates to ensure it demonstrates the bug. Add the test its baselines in one commit

.github/copilot-instructions.md:3

  • The path test/cases/compiler seems inconsistent with tests/cases/fourslash. Consider using tests/cases/compiler to match the existing folder structure.
 * Only add testcases in `test/cases/compiler` or `tests/cases/fourslash`. Do not write direct unit tests.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Jun 18, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants