Skip to content

Fixed references search for dynamic imports of indirect default exports #61379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andarist wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed references search for dynamic imports of indirect default exports #61379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/services/findAllReferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,12 @@ export namespace Core {
break;
case ExportKind.Default:
// Search for a property access to '.default'. This can't be renamed.
indirectSearch = state.options.use === FindReferencesUse.Rename ? undefined : state.createSearch(exportLocation, exportSymbol, ImportExport.Export, { text: "default" });
if (state.options.use !== FindReferencesUse.Rename) {
const allSearchSymbols = [exportSymbol];
const defaultExportSymbol = exportInfo.exportingModuleSymbol.exports?.get(InternalSymbolName.Default);
if (defaultExportSymbol && exportSymbol !== defaultExportSymbol) allSearchSymbols.push(defaultExportSymbol);
indirectSearch = state.createSearch(exportLocation, exportSymbol, ImportExport.Export, { text: "default", allSearchSymbols });
}
break;
case ExportKind.ExportEquals:
break;
Expand Down
Loading