Skip to content

Conversation

@tristonarmstrong
Copy link

@tristonarmstrong tristonarmstrong commented Oct 18, 2024

Note

There is no Issue open for this with the help wanted tag. I created this because me, and others, have needed something like this quite a few times. So I'm doing it anyway

This is a very similar solution to how the deprecated label works. There is a slight difference, and needs to be treated differently so that editors can label them accordingly. Right now, the labels look exactly the same aside from the text indicating its experimental. It still does well with notifying the user, and bringing their attention to the token, but its not good enough.

Checklist

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run hereby runtests locally
  • There are new or updated unit tests validating the change

Fixes #56808

Update (2025): I've not worked on this in quite a while. I will get back to this soon, but I first need to update the branch with its upstream which will likely result in a plethora of issues. I also need to look into if this work has already been done by now or in the works so I don't do double work.

link to example of it working

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 18, 2024
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@tristonarmstrong
Copy link
Author

Didn't realize a draft pr would go pinging everyone lol My bad, I just wanted to see what this process would look like.

@tristonarmstrong
Copy link
Author

@microsoft-github-policy-service agree - for when/if this becomes a legit thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@experimental JSDoc tag, with strikethrough style (or similar) like @deprecated JSDoc tag

2 participants