Some of the test refactoring and readable baselining #56075
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
| getLanguageService(): never; | ||
| getHostForAutoImportProvider(): never; | ||
| getProjectReferences(): readonly ts.ProjectReference[] | undefined; | ||
| getTypeAcquisition(): TypeAcquisition; |
There was a problem hiding this comment.
Is this an intentional change?
There was a problem hiding this comment.
It isnt test only change but i had done this as part of #56074 first and since it has no impact, left it there
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Largely this looks good to me, though I just have the one comment about the API change, which doesn't feel intentional in a test-only change.
| ); | ||
| addInferredTypings(module, "Inferred typings from unresolved imports"); | ||
| } | ||
| // Remove typings that the user has added to the exclude list |
There was a problem hiding this comment.
This is order change and shouldnt have any impact as such on functionality a359540
| return PackageJsonAutoImportPreference.Off; | ||
| } | ||
|
|
||
| override getTypeAcquisition(): TypeAcquisition { |
There was a problem hiding this comment.
This shouldnt be needed since default typeAcquisition is always disabled ae1b510
Pulled out from #56074