Fix error and error-behind css classes out-of-sync#3400
Merged
jakebailey merged 1 commit intomicrosoft:v2from May 29, 2025
Merged
Fix error and error-behind css classes out-of-sync#3400jakebailey merged 1 commit intomicrosoft:v2from
jakebailey merged 1 commit intomicrosoft:v2from
Conversation
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3400.centralus.5.azurestaticapps.net |
jakebailey
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
error-behindin some cases line breaks beforeerrordoes, e.g. in docs/handbook/2/objects.html:you can see
of the
error-behind, which is supposed to be invisible, in the next line.The problem is that the CSS classes
errorandbehind-errorare slightly out of sync:margin-right: -2pxis obsoleteerrorshould be6px 8px 6px 12px6px 6px 6px 14px, but14pxis too much since the ancestor<pre class="shiki light-plus twoslash lsp" ...>has a border of1px+12pxpaddingerrorclass has aborder-right: 2pxwhich hangs1pxover the border of the<pre>element, the padding should be12px8pxcompensates the removedmargin-right: -2pxerror-behindspan line breaks before theerrorspanerroris absolute, it ignores the right padding of the ancestor<pre>of12pxerrorneeds amargin-right: 12pxto wrap simultaneously