Skip to content

Implement LWG-2746 Inconsistency between requirements for emplace between optional and variant#6234

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
frederick-vs-ja:lwg-2746
Apr 17, 2026
Merged

Implement LWG-2746 Inconsistency between requirements for emplace between optional and variant#6234
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
frederick-vs-ja:lwg-2746

Conversation

@frederick-vs-ja
Copy link
Copy Markdown
Contributor

Fixes #6200.

It should be sufficient to just test that optional::emplace correctly behaves in SFINAE.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner April 7, 2026 09:52
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 7, 2026
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Apr 7, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Apr 13, 2026
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 15, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej merged commit 8f5fe36 into microsoft:main Apr 17, 2026
49 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 17, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member

🐈 😺 💚

@frederick-vs-ja frederick-vs-ja deleted the lwg-2746 branch April 17, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

LWG-2746 Inconsistency between requirements for emplace between optional and variant

2 participants