Skip to content

Track time spend in add_result #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenshnielsen merged 2 commits into from
Dec 11, 2025
Merged

Track time spend in add_result #7705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
044d061
Track time spend in add_result
jenshnielsen Dec 11, 2025
a361885
Avoid roundoff errors
jenshnielsen Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/qcodes/dataset/measurements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from inspect import signature
from itertools import chain
from numbers import Number
from time import perf_counter
from time import perf_counter, perf_counter_ns
from typing import TYPE_CHECKING, Any, TypeAlias, TypeVar, cast

import numpy as np
Expand Down Expand Up @@ -67,6 +67,7 @@
log = logging.getLogger(__name__)
TRACER = trace.get_tracer(__name__)


ActionType = tuple[Callable[..., Any], Sequence[Any]]
SubscriberType = tuple[
Callable[..., Any], MutableSequence[Any] | MutableMapping[Any, Any]
Expand Down Expand Up @@ -98,6 +99,7 @@ def __init__(
) -> None:
self._span = span
self._dataset = dataset
self._add_result_time_ns = 0
if (
DataSaver.default_callback is not None
and "run_tables_subscription_callback" in DataSaver.default_callback
Expand Down Expand Up @@ -207,6 +209,7 @@ def add_result(self, *result_tuples: ResType) -> None:
its type.

"""
start_time = perf_counter_ns()

parameter_results: list[ParameterResultType] = [
self._coerce_result_tuple_to_parameter_result_type(result_tuple)
Expand Down Expand Up @@ -277,6 +280,7 @@ def add_result(self, *result_tuples: ResType) -> None:
if perf_counter() - self._last_save_time > self.write_period:
self.flush_data_to_database()
self._last_save_time = perf_counter()
self._add_result_time_ns += perf_counter_ns() - start_time

def _unpack_arrayparameter(
self, partial_result: ResType
Expand Down Expand Up @@ -734,6 +738,8 @@ def __exit__(
with DelayedKeyboardInterrupt(
context={"reason": "qcodes measurement exit", "qcodes_guid": self.ds.guid}
):
add_result_time = self.datasaver._add_result_time_ns
self._span.set_attribute("qcodes_add_result_time_ms", add_result_time / 1e6)
self.datasaver.flush_data_to_database(block=True)

# perform the "teardown" events
Expand Down
Loading