Skip to content

Conversation

@abhishekbedi1432
Copy link

@abhishekbedi1432 abhishekbedi1432 commented Jan 28, 2026

Description

Increased MAX_ENTRIES limit from 10,000 to 20,000 in ZipBombChecker.java to support uploading larger test packages with more files.

Problem: Test packages (e.g., iOS XCTest bundles) can contain more than 10,000 files, causing the zip bomb detection to incorrectly reject legitimate uploads.

Solution: Increased the MAX_ENTRIES constant to 20,000 to accommodate larger packages while still protecting against zip bomb attacks.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

How you tested it

  • Built and ran :common:test - all tests pass
  • Verified that a test package with 11,321 files (previously rejected) can now be uploaded

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

N/A - Configuration change only.

@abhishekbedi1432 abhishekbedi1432 changed the title Update ZipBombChecker.java Increase MAX_ENTRIES limit in ZipBombChecker to support larger test packages Jan 28, 2026
@hydraxman hydraxman enabled auto-merge (squash) January 29, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants