build(client): build:compile:esm:packages - fast production ESM build#26769
Draft
jason-ha wants to merge 2 commits intomicrosoft:mainfrom
Draft
build(client): build:compile:esm:packages - fast production ESM build#26769jason-ha wants to merge 2 commits intomicrosoft:mainfrom
jason-ha wants to merge 2 commits intomicrosoft:mainfrom
Conversation
`fluid-build --task build:esnext` should be able to complete without needing to build CommonJS. 1. Remove extraneous `^tsc` dependencies in examples. 2. Reduce general `build:esnext` to not depend on `^tsc` and `^api`. 3. Reduce presence `^api` dependencies to `^api-extractor:esnext` and `^api-extractor:commonjs`. Note general `tsc` dependency is left to depend on `^api` and `^build:esnext`.
Additional changes required for complete ESM package generation (sans tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm build:compile:esm:packageswill do a minimal ESM only package build.Can be used to check validity of production code without hitting test collateral (except for a few test-oriented packages).
build:esnexttasks (fluid-build --task build:esnext) are able to complete without needing to build CommonJS with these changes:^tscdependencies in examples.build:esnextto not depend on^tscand^api.^apidependencies to^api-extractor:esnextand^api-extractor:commonjs.property-propertieswould build using CommonJSproperty-changeset.Note general
tscdependency is left to depend on^apiand^build:esnext.