Share code to Add VectorAccumulate and InterpretedVector Multiply#8435
Open
pow2clk wants to merge 3 commits intomicrosoft:mainfrom
Open
Share code to Add VectorAccumulate and InterpretedVector Multiply#8435pow2clk wants to merge 3 commits intomicrosoft:mainfrom
pow2clk wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Consists of little more than adding the dxil op, builtin, and trivial header call. I even reused the lowering function from coopvec.
Collaborator
Author
|
@V-FEXrt for visibility |
V-FEXrt
reviewed
May 8, 2026
|
|
||
| op_table.reserve_dxil_op_range("ReservedE", 2) | ||
| add_dxil_op( | ||
| "LinAlgVectorAccumulateToDescriptor", |
Collaborator
There was a problem hiding this comment.
per the spec, this should be VectorAccumulateToDescriptor (op is named @dx.op.vectorAccumulateToDescriptor) though I do find that to be a strange break from the rest of the operations.
It either needs to be changed here or in the spec
Collaborator
|
Thanks for putting this up! Looks pretty much exactly as I'd expect it would. Just to confirm, would you like us to take over the PR to implement the full test suite or would you like me to give you pointers so you can write the rest of the tests yourself? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing the code that adds VectorAccumulate and the Mat/Vec Multiply overload that takes an interpreted vector. A test is included, but it is likely not in the form required.
These commits can be accepted as-is and enhanced later or the code taken and modified before submission. The test has prerequisites that force the commits to be grouped like this, but could be teased apart and probably should be.