[build][fix][x86] Fixes a compiler error on x86 targets#8348
Merged
V-FEXrt merged 1 commit intomicrosoft:mainfrom Apr 7, 2026
Merged
[build][fix][x86] Fixes a compiler error on x86 targets#8348V-FEXrt merged 1 commit intomicrosoft:mainfrom
V-FEXrt merged 1 commit intomicrosoft:mainfrom
Conversation
jenatali
approved these changes
Apr 7, 2026
tex3d
approved these changes
Apr 7, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good. To be clear, this doesn't break in all x86 builds, it depends on the build flags (presumably /Gz), which is why we didn't catch it until now. Since this code is built in other projects, it's important to be explicit about this calling convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8256 pulled in new commits from upstream but didn't update a function signature causing a build failure on x86 targets. This PR fixes the signature