Remove non-standard nothrow specializations#8303
Open
minchopaskal wants to merge 1 commit intomicrosoft:mainfrom
Open
Remove non-standard nothrow specializations#8303minchopaskal wants to merge 1 commit intomicrosoft:mainfrom
minchopaskal wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
@minchopaskal please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
It looks like the code is removed in this PR was very deliberately added. Before we can accept this, we'd need to understand that removing it doesn't regress the scenario it was intended to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #7098
The specialisations of
is_nothrow_constructibleinStringRef.hare non-standard and as seen in the issue fail with newer versions of libc++.Manage to compile on MacOS 26.4(clang-2100.0.123.102). The static checks in
DiagnosticIDs.cppremain though so if there is an issue the builds should show it.