[SM6.10] Update LinAlg Matrix ComponentType enum#8298
[SM6.10] Update LinAlg Matrix ComponentType enum#8298hekota wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Component types valid for LinAlg Matrix are a subset of existing DXIL component type constants.
hekota
changed the title
|
|
||
| namespace dxil { | ||
|
|
||
| // This enum is be _exactly_ the DXIL constants. |
There was a problem hiding this comment.
| // This enum is be _exactly_ the DXIL constants. | |
| // This enum must _exactly_ match the DXIL constants. |
There was a problem hiding this comment.
Although.....is this really a thing we want in the user-visible header?
There was a problem hiding this comment.
Not sure what we can actually do here to make this better but I had a similar thought. Would be nice if we could magically depend on the C++ version of the header but that doesn't really make sense
There was a problem hiding this comment.
IMO the values happening to match DXIL is an implementation detail that wouldn't necessarily hold / make sense with a SPIRV implementation.
There was a problem hiding this comment.
In this case, the spec mandates that they match! We might change that for SPIRV but at least for now I'm not sure I'd call it an implementation detail
| __COMPONENT_TYPE(F16), | ||
| __COMPONENT_TYPE(F32), | ||
| __COMPONENT_TYPE(F64), | ||
| }; |
3 participants
Component types valid for LinAlg Matrix are a subset of existing DXIL component type constants.
Spec: LinAlg hlsl-header
Part of #7839