[SM6.10] Update Values for Component Types#8264
[SM6.10] Update Values for Component Types#8264V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
I8 and U8 were in an inconsistent order compared to all the other previously defined types. The values are swapped now as they were only ever used for coopvec which never left preview and is removed from future releases. The upcoming LinAlg feature will depend on these values so they must be updated now.
|
I think this change breaks the contract between any drivers that implement preview cooperative vectors. Should we just do #8147 now and be done with it? |
It does yes
We should yes, I was trying to make the minimal change needed for the LinAlg preview but we could potentially just do the larger thing now |
|
@damyanp any further thoughts here? This PR will be a blocker for the HLK stuff fairly soon My opinion is that it's not a huge deal to break preview drivers since we essentially broke them in the last release but willing to be told that I'm wrong and we should rip the whole thing out:) |
|
I think we should ASAP remove any pretense that we're supporting the preview cooperative vectors feature in main. My concern with this change is that it now looks like we're supporting a broken version of the feature. |
I8 and U8 were in an inconsistent order compared to all the other previously defined types. The values are swapped now as they were only ever used for coopvec which never left preview and is removed from future releases. The upcoming LinAlg feature will depend on these values so they must be updated now.