Skip to content

[SM6.10] Update Values for Component Types#8264

Open
V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
V-FEXrt:component-type-values
Open

[SM6.10] Update Values for Component Types#8264
V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
V-FEXrt:component-type-values

Conversation

@V-FEXrt
Copy link
Collaborator

@V-FEXrt V-FEXrt commented Mar 13, 2026

I8 and U8 were in an inconsistent order compared to all the other previously defined types. The values are swapped now as they were only ever used for coopvec which never left preview and is removed from future releases. The upcoming LinAlg feature will depend on these values so they must be updated now.

I8 and U8 were in an inconsistent order compared to all the other
previously defined types. The values are swapped now as they were only
ever used for coopvec which never left preview and is removed from
future releases. The upcoming LinAlg feature will depend on these values
so they must be updated now.
@damyanp
Copy link
Member

damyanp commented Mar 13, 2026

I think this change breaks the contract between any drivers that implement preview cooperative vectors. Should we just do #8147 now and be done with it?

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Mar 13, 2026

I think this change breaks the contract between any drivers that implement preview cooperative vectors

It does yes

Should we just do #8147 now and be done with it?

We should yes, I was trying to make the minimal change needed for the LinAlg preview but we could potentially just do the larger thing now

@V-FEXrt
Copy link
Collaborator Author

V-FEXrt commented Mar 18, 2026

@damyanp any further thoughts here? This PR will be a blocker for the HLK stuff fairly soon

My opinion is that it's not a huge deal to break preview drivers since we essentially broke them in the last release but willing to be told that I'm wrong and we should rip the whole thing out:)

@damyanp
Copy link
Member

damyanp commented Mar 19, 2026

I think we should ASAP remove any pretense that we're supporting the preview cooperative vectors feature in main. My concern with this change is that it now looks like we're supporting a broken version of the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants