Cherry-Pick #7574: [NFC] Address compiler warnings: C4146 - A grab bag of remaining instances#8238
Draft
alsepkow wants to merge 1 commit intomicrosoft:release-1.8.2505from
Conversation
…stances (microsoft#7574) ## Fix C4146 warnings: unary minus on unsigned types Fixes several remaining MSVC C4146 warnings where unary minus was applied to unsigned integers. This should be the last PR containing MSVC C4146 warning fixes. I will remove the disablement of the warning as an error in a subsequent PR once the other pending PRs are completed. **Changes:** - Replace `-(unsigned_value)` with `~unsigned_value + 1` for offset calculations - Use `-1LL` instead of `-1ULL` where signed values are intended - Fix alignment padding calculation to avoid unsigned negation **Files changed:** - CoverageMappingGen.cpp, Lexer.cpp, Rewriter.cpp: Use two's complement for safe unsigned negation in offset calculations - ItaniumCXXABI.cpp: Use signed literal for ABI-compliant null member pointer (-1) - ExprConstant.cpp: Replace `-1ULL` with `~0ULL` for bitmasks - CodeGenMapTable.cpp: Fix sentinel value generation All changes are mathematically equivalent and preserve existing behavior while eliminating compiler warnings. Addresses microsoft#7573
alsepkow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7574 into release-1.8.2505.
Original PR: #7574
Original Commit: 23118b9
Assisted by GitHub Copilot.