Fix crash in CanConvert from incomplete type#8110
Open
tex3d wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix crash in CanConvert from incomplete type#8110tex3d wants to merge 2 commits intomicrosoft:mainfrom
tex3d wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…e selection A crash could be triggered in IsHLSLCopyableAnnotatableRecord when checking whether an explicit cast would be allowed for diagnostics, when adding function overload candidates with an incomplete target param type, and the source type is a basic type that supports splat to record type. Fixed by attempting to complete the type in CanConvert before calling IsHLSLNumericOrAggregateOfNumericType (which calls IsHLSLCopyableAnnotatableRecord). If it fails to complete, it will harmlessly skip this case.
llvm-beanz
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crash could be triggered in IsHLSLCopyableAnnotatableRecord when checking whether an explicit cast would be allowed for diagnostics, when adding function overload candidates with an incomplete target param type, and the source type is a basic type that supports splat to record type.
Fixed by attempting to complete the type in CanConvert before calling IsHLSLNumericOrAggregateOfNumericType (which calls IsHLSLCopyableAnnotatableRecord). If it fails to complete, it will harmlessly skip this case.