-
Notifications
You must be signed in to change notification settings - Fork 309
[27.x][Backport] [Event Request] [Subscription Billing] table 8063 "Vendor Subscription Contract" internal procedure CreateVendorContractLineFromServiceCommitment #6092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
samra-singhammer
wants to merge
51
commits into
microsoft:releases/27.x
from
samra-singhammer:BackportCreateVendorContractLineFromServiceCommitment27.x
Closed
[27.x][Backport] [Event Request] [Subscription Billing] table 8063 "Vendor Subscription Contract" internal procedure CreateVendorContractLineFromServiceCommitment #6092
samra-singhammer
wants to merge
51
commits into
microsoft:releases/27.x
from
samra-singhammer:BackportCreateVendorContractLineFromServiceCommitment27.x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Final integration to 27.0 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#597872](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597872) --------- Co-authored-by: Quentin Tresontani <31541422+qutreson@users.noreply.github.com> Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com> Co-authored-by: business-central-bot[bot] <205154211+business-central-bot[bot]@users.noreply.github.com> Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
…oft#4551) This PR contains the following changes: - Update BCArtifact version. New value: 27.0.38571.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) --------- Co-authored-by: mazhelez <mazhelez@users.noreply.github.com> Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
…om a single place (microsoft#4580) This pull request backports microsoft#4501 to releases/27.0 Fixes [AB#598714](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598714)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Add CLEAN28 to AL-Go-Settings.json #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#597870](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597870)
…ase/latest (microsoft#4610) This PR contains the following changes: - Update BCArtifact version. New value: 27.0.38460.38647 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) --------- Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com> Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
…emplate using latest setup table (microsoft#4556) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Port from microsoft#4507 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#593746](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/593746)
This pull request backports microsoft#4512 to releases/27.0 Fixes [AB#598727](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598727) Fixes [AB#598729](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598729) Fixes [AB#598731](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598731) Fixes [AB#598744](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598744)
…rosoft#4615) #### Summary Adding support for selecting the language from the agent setup card #### Work Item(s) Fixes [AB#596383](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/596383)
…829 (+ 1 more update(s)) (microsoft#4649) This PR contains the following changes: - Update app baselines package version. New value: 26.4.37194.38829 - Update translation package version. New value: 27.0.25239.3 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
) This pull request backports microsoft#4617 to releases/27.0 Fixes [AB#599062](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599062)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Port from microsoft#4461 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#599347](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599347)
…not enabled (microsoft#4658) This pull request backports microsoft#4628 to releases/27.0 Fixes [AB#599038](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599038)
…ements (microsoft#4656) This pull request backports microsoft#4629 to releases/27.0 Fixes [AB#599306](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599306)
When Subscription Billing app creates a new billing document it validates the vendor number and posting date. Then the IRS forms app, which is the US specific app, not related to subscription billing, run an update of certain fields related to this app. This kind of update in the IRS forms app from the other side triggers the Subscription billing app code - the CreatePurchaseHeaderForVendorNo procedure. This procedure throws the following error: You cannot make this change because the document is linked to a contract. If you still want to change the field, first delete this document and then make the change to the contract. This procedure has a list of fields for exclusion. It would be great to add IRS forms app fields to the exclusion list, but that is not possible unless i create a dependency between these two apps, which does not make any sense. The other approach which i eventually chose is to skip calling the CreatePurchaseHeaderForVendorNo when i change the vendor number pr posting date. To me it sounds much better as we keep the procedure untouched, so we continue to call it whenever some user changes this value in the document. But if we validate the posting date through the code in the CreateBillingDocuments codeunit, we can skip this check. [AB#599229](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599229)
…067 (microsoft#4730) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.39067 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…4734) Fixes [AB#571288](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571288) Co-authored-by: Vasil Iliev <vasililiev@users.noreply.github.com> Co-authored-by: Vasil Iliev <vailiev@microsoft.com>
…lines (microsoft#4690) This pull request backports microsoft#4626 to releases/27.0 Fixes AB#[**Insert Work Item Number Here**]
…word since SecretTexts cannot be compared in Cloud - missing capability in 27 compared to 26! - Copy (microsoft#4752) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Backport of microsoft#4654 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602448](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602448) Co-authored-by: bc4all <104026807+bc4all@users.noreply.github.com>
…518 (microsoft#4785) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.39518 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> [27.0] Disable tests in Contract Renewal Test to unblock CI/CD https://github.com/microsoft/BCApps/actions/runs/17848140287 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#603826](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/603826)
…811 (microsoft#4848) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.39811 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…permis… (microsoft#4854) "Add Related Fields" permission is not part of any user permission sets , therefore uptake is cubersome since admins need to know about this permission and assign it to the users. The PM decision is to include "Add Related Fields" permission in Basic permision set. Fixes [AB#604297](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/604297)
…rency to avoid fake "Processing" email block email sending (microsoft#4895) This pull request backports microsoft#4820 to releases/27.0 Fixes [AB#606061](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/606061)
…209 (microsoft#4918) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.40209 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…/base/latest (microsoft#4976) This PR contains the following changes: - Update BCArtifact version. New value: bcartifacts/Sandbox/27.0/base/latest [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
…th publicDisplayName (microsoft#4979) This pull request backports microsoft#4877 to releases/27.0 Fixes [AB#608911](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/608911)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Updated the **InitValue** property for two fields for two tables #### Rationale - Ensures that newly created records have the correct default values set automatically. - Reduces user confusion and prevents missing/incorrect defaults during data entry. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#4871 Fixes [AB#608986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/608986) Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>
…//latest (microsoft#5038) This PR contains the following changes: - Update BCArtifact version. New value: bcartifacts/Sandbox/27.0//latest [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: BazookaMusic <BazookaMusic@users.noreply.github.com>
…541 (microsoft#5065) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.40541 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…icrosoft#5092) #### Summary For a contract starting on **27.02.2020**, billed quarterly with **"Align to End of Month"** enabled: This fix corrects the **Billing-To Date** calculation for quarterly contracts that use the **"Align to End of Month"** option. - For example, a contract starting on **27.02.2020** with the first billing period split manually (**27.02.2020–29.02.2020**) and the next period beginning **01.03.2020** should end on **31.05.2020**. - Previously, the system incorrectly calculated the end date as **27.06.2020**. - The fix ensures that when the start of the billing period is adjusted to the **first of the month**, the system correctly determines the end of the full billing quarter, preserving alignment with the “End of Month” rule. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#5089 Fixes [AB#609479](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/609479) Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>
…184 (microsoft#5245) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.41184 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…452 (microsoft#5319) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.41452 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…#5307) #### Summary Only append an asterisk to the Line Amount for Document Type Quote and Order. #### Work Item(s) Fixes microsoft#5285 Fixes [AB#611364](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611364) Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
…e no changes (microsoft#5368) #### Summary <!-- Provide a general summary of your changes --> Backport of microsoft#4808 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#611473](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611473) Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
…739 (microsoft#5415) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.41739 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…977 (microsoft#5459) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.41977 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…305 (microsoft#5530) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.42305 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports microsoft#5495 to releases/27.0 Fixes AB#613484
…607 (microsoft#5605) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.42607 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…tionPossibleUntilAndTermUntilWhenNoticePeriodIsEmpty (microsoft#5675) This pull request backports microsoft#5673 to releases/27.0 Fixes [AB#615120](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615120)
…880 (microsoft#5666) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.42880 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…239 (microsoft#5757) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.43239 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…eList node (microsoft#5798) This pull request backports microsoft#5777 to releases/27.0 Fixes [AB#615937](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615937)
…554 (microsoft#5852) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.43554 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…128 (microsoft#6032) This PR contains the following changes: - Update app baselines package version. New value: 26.5.38752.44128 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
Contributor
Author
|
@pri-kise Can you please check the backporting branch as well? It was based on upstream/releases/27.0. |
Contributor
|
You need to create a branch with the base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: Apps (W1)
Add-on apps for W1
AL: Business Foundation
AL: System Application
Build: Automation
Workflows and other setup in .github folder
Build: scripts & configs
Build scripts and configuration files
From Fork
Pull request is coming from a fork
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposure of procedure CreateVendorContractLineFromServiceCommitment
Work Item(s)
Fixes #6043
Backport of: #6091