Skip to content

Conversation

@samra-singhammer
Copy link
Contributor

@samra-singhammer samra-singhammer commented Jan 9, 2026

Summary

Exposure of procedure CreateVendorContractLineFromServiceCommitment

Work Item(s)

Fixes #6043
Backport of: #6091

aholstrup1 and others added 30 commits August 26, 2025 22:25
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Final integration to 27.0

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Related to
[AB#597872](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597872)

---------

Co-authored-by: Quentin Tresontani <31541422+qutreson@users.noreply.github.com>
Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
Co-authored-by: business-central-bot[bot] <205154211+business-central-bot[bot]@users.noreply.github.com>
Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
…oft#4551)

This PR contains the following changes:
- Update BCArtifact version. New value: 27.0.38571.0


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

---------

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Add CLEAN28 to AL-Go-Settings.json

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Related to
[AB#597870](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597870)
…ase/latest (microsoft#4610)

This PR contains the following changes:
- Update BCArtifact version. New value: 27.0.38460.38647


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

---------

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
…emplate using latest setup table (microsoft#4556)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Port from microsoft#4507

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#593746](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/593746)
…829 (+ 1 more update(s)) (microsoft#4649)

This PR contains the following changes:
- Update app baselines package version. New value: 26.4.37194.38829
- Update translation package version. New value: 27.0.25239.3


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->

Port from microsoft#4461

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#599347](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599347)
When Subscription Billing app creates a new billing document it
validates the vendor number and posting date. Then the IRS forms app,
which is the US specific app, not related to subscription billing, run
an update of certain fields related to this app. This kind of update in
the IRS forms app from the other side triggers the Subscription billing
app code - the CreatePurchaseHeaderForVendorNo procedure. This procedure
throws the following error:
You cannot make this change because the document is linked to a
contract. If you still want to change the field, first delete this
document and then make the change to the contract.

This procedure has a list of fields for exclusion. It would be great to
add IRS forms app fields to the exclusion list, but that is not possible
unless i create a dependency between these two apps, which does not make
any sense.
The other approach which i eventually chose is to skip calling the
CreatePurchaseHeaderForVendorNo when i change the vendor number pr
posting date. To me it sounds much better as we keep the procedure
untouched, so we continue to call it whenever some user changes this
value in the document. But if we validate the posting date through the
code in the CreateBillingDocuments codeunit, we can skip this check.



[AB#599229](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599229)
…067 (microsoft#4730)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.39067


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…4734)

Fixes

[AB#571288](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571288)

Co-authored-by: Vasil Iliev <vasililiev@users.noreply.github.com>
Co-authored-by: Vasil Iliev <vailiev@microsoft.com>
…lines (microsoft#4690)

This pull request backports microsoft#4626 to releases/27.0

Fixes AB#[**Insert Work Item Number Here**]
…word since SecretTexts cannot be compared in Cloud - missing capability in 27 compared to 26! - Copy (microsoft#4752)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Backport of microsoft#4654

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#602448](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602448)

Co-authored-by: bc4all <104026807+bc4all@users.noreply.github.com>
…518 (microsoft#4785)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.39518


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
[27.0] Disable tests in Contract Renewal Test to unblock CI/CD 
https://github.com/microsoft/BCApps/actions/runs/17848140287

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#603826](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/603826)
…811 (microsoft#4848)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.39811


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…permis… (microsoft#4854)

"Add Related Fields" permission is not part of any user permission sets
, therefore uptake is cubersome since admins need to know about this
permission and assign it to the users.
The PM decision is to include "Add Related Fields" permission in Basic
permision set.

Fixes
[AB#604297](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/604297)
…rency to avoid fake "Processing" email block email sending (microsoft#4895)

This pull request backports microsoft#4820 to releases/27.0

Fixes
[AB#606061](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/606061)
…209 (microsoft#4918)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.40209


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…/base/latest (microsoft#4976)

This PR contains the following changes:
- Update BCArtifact version. New value:
bcartifacts/Sandbox/27.0/base/latest


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md -->
#### Summary <!-- Provide a general summary of your changes --> Updated
the **InitValue** property for two fields for two tables

#### Rationale

- Ensures that newly created records have the correct default values set
automatically.
- Reduces user confusion and prevents missing/incorrect defaults during
data entry.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes microsoft#4871

Fixes
[AB#608986](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/608986)

Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>
…//latest (microsoft#5038)

This PR contains the following changes:
- Update BCArtifact version. New value: bcartifacts/Sandbox/27.0//latest


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: BazookaMusic <BazookaMusic@users.noreply.github.com>
…541 (microsoft#5065)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.40541


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…icrosoft#5092)

#### Summary

For a contract starting on **27.02.2020**, billed quarterly with
**"Align to End of Month"** enabled:

This fix corrects the **Billing-To Date** calculation for quarterly
contracts that use the **"Align to End of Month"** option.

- For example, a contract starting on **27.02.2020** with the first
billing period split manually (**27.02.2020–29.02.2020**) and the next
period beginning **01.03.2020** should end on **31.05.2020**.
- Previously, the system incorrectly calculated the end date as
**27.06.2020**.
- The fix ensures that when the start of the billing period is adjusted
to the **first of the month**, the system correctly determines the end
of the full billing quarter, preserving alignment with the “End of
Month” rule.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes microsoft#5089 
Fixes

[AB#609479](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/609479)

Co-authored-by: Miljan Milosavljević <miljan83@gmail.com>
business-central-bot bot and others added 16 commits October 21, 2025 11:33
…184 (microsoft#5245)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.41184


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…452 (microsoft#5319)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.41452


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…#5307)

#### Summary
Only append an asterisk to the Line Amount for Document Type Quote and
Order.

#### Work Item(s) 
Fixes microsoft#5285
Fixes
[AB#611364](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611364)

Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
…e no changes (microsoft#5368)

#### Summary <!-- Provide a general summary of your changes -->

Backport of microsoft#4808

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#611473](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611473)

Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
…739 (microsoft#5415)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.41739


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…977 (microsoft#5459)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.41977


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…305 (microsoft#5530)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.42305


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports microsoft#5495 to releases/27.0

Fixes AB#613484
…607 (microsoft#5605)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.42607


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…880 (microsoft#5666)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.42880


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…239 (microsoft#5757)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.43239


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…554 (microsoft#5852)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.43554


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…128 (microsoft#6032)

This PR contains the following changes:
- Update app baselines package version. New value: 26.5.38752.44128


[AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394)

Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
@samra-singhammer samra-singhammer requested review from a team as code owners January 9, 2026 08:26
@github-actions github-actions bot added Build: Automation Workflows and other setup in .github folder AL: System Application Build: scripts & configs Build scripts and configuration files AL: Business Foundation AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jan 9, 2026
@samra-singhammer
Copy link
Contributor Author

@pri-kise Can you please check the backporting branch as well? It was based on upstream/releases/27.0.

@pri-kise
Copy link
Contributor

pri-kise commented Jan 9, 2026

You need to create a branch with the base upstream/releases/27.x.
I would suggest to recreate this backport branch.

@samra-singhammer samra-singhammer deleted the BackportCreateVendorContractLineFromServiceCommitment27.x branch January 9, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 AL: Business Foundation AL: System Application Build: Automation Workflows and other setup in .github folder Build: scripts & configs Build scripts and configuration files From Fork Pull request is coming from a fork

Projects

None yet

Development

Successfully merging this pull request may close these issues.