-
Notifications
You must be signed in to change notification settings - Fork 308
[Shopify] GraphQL cost audit #5926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbuyuka
commented
Dec 23, 2025
src/Apps/W1/Shopify/App/src/Base/Codeunits/ShpfyCommunicationMgt.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreiPanko
reviewed
Jan 6, 2026
src/Apps/W1/Shopify/App/src/GraphQL/Codeunits/ShpfyGQLGetFulfillments.Codeunit.al
Outdated
Show resolved
Hide resolved
AndreiPanko
reviewed
Jan 6, 2026
src/Apps/W1/Shopify/App/src/GraphQL/Codeunits/ShpfyGQLLocationOrderLines.Codeunit.al
Outdated
Show resolved
Hide resolved
darjoo
previously approved these changes
Jan 6, 2026
AndreiPanko
requested changes
Jan 6, 2026
Contributor
AndreiPanko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two queries have {{NumberOfLines}} pr alike parameter that seems to be set as 1. I suspect the real value is different
…609930-ShpfyGQLCost
AndreiPanko
previously approved these changes
Jan 7, 2026
Contributor
|
Why not check the powershell script in here? |
onbuyuka
commented
Jan 7, 2026
src/Apps/W1/Shopify/App/src/PermissionSets/ShpfyObjects.PermissionSet.al
Show resolved
Hide resolved
onbuyuka
commented
Jan 7, 2026
src/Apps/W1/Shopify/App/src/PermissionSets/ShpfyObjects.PermissionSet.al
Show resolved
Hide resolved
AndreiPanko
approved these changes
Jan 8, 2026
JesperSchulz
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify GraphQL Cost Audit
Overview
The
GetExpectedCost()values in the GraphQL codeunits were audited against Shopify's actual API costs using API version 2025-07.Method
Created GetShopifyCosts.ps1 script that:
GetGraphQL()method{{ProductId}},{{OrderId}}, etc.) with dummy valuesrequestedQueryCostfrom the responseextensions.costobjectGetExpectedCost()valueScript handles AL string escaping (
''for single quotes) to properly extract queriesUpdates files in-place when run with
-UpdateFilesflagResults
Notable Corrections
Files Requiring Manual Review
These files couldn't be validated due to complex placeholder requirements:
ShpfyGQLCreatePriceList- B2B catalog mutationShpfyGQLMetafieldsSet- Requires metafields array inputShpfyGQLOrderCancel- Requires boolean/enum placeholdersShpfyGQLNextOrderReturns- Returns featureShpfyGQLRevFulfillOrderLines/ShpfyGQLNextRevFulfillOrdLns- Reverse fulfillmentShpfyGQLTranslationsRegister- Translation mutationShpfyGQLUpdateOrderAttr- Order attributes mutationWork Item(s)
Fixes AB#609930