Update OTLP Metric Exporter Creation #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
approved these changes
Sep 29, 2025
rads-1996
reviewed
Sep 29, 2025
hectorhdzg
reviewed
Sep 29, 2025
rads-1996
reviewed
Sep 29, 2025
rads-1996
reviewed
Sep 29, 2025
rads-1996
reviewed
Sep 29, 2025
| ); | ||
|
|
||
| // Create metricReaders array and add OTLP reader if environment variables request it | ||
| try { |
Member
There was a problem hiding this comment.
No changelog update? Or did I miss it?
Contributor
Author
There was a problem hiding this comment.
This project does not have a changelog. Open to adding one in another PR.
Member
There was a problem hiding this comment.
Interesting, if it makes sense to have a CHANGELOG for these changes, then adding that to another PR sounds like a plan.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how the
AKSLoaderclass detects and configures the OTLP metric exporter based on theOTEL_METRICS_EXPORTERenvironment variable. The main change is to ensure that "otlp" is recognized correctly when specified as a comma-separated value among other exporters, and not as part of another word. Several new unit tests were added to verify this behavior for different scenarios.Logic improvements to OTLP exporter detection:
AKSLoaderto check for "otlp" as a distinct value in theOTEL_METRICS_EXPORTERenvironment variable, supporting comma-separated lists and ignoring partial matches (e.g., "otlp-custom" does not trigger the exporter). (src/agent/aksLoader.ts)Expanded test coverage for exporter detection:
OTEL_METRICS_EXPORTERvalue. (test/unitTests/agent/aksLoader.tests.ts)test/unitTests/agent/aksLoader.tests.ts)