-
Notifications
You must be signed in to change notification settings - Fork 144
Add 15 Second Delay to Long Interval Statsbeat & Fix Tests #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JacksonWeber
merged 12 commits into
microsoft:2.x
from
JacksonWeber:jacksonweber/15-second-delay
Jul 2, 2025
Merged
Add 15 Second Delay to Long Interval Statsbeat & Fix Tests #1440
JacksonWeber
merged 12 commits into
microsoft:2.x
from
JacksonWeber:jacksonweber/15-second-delay
Jul 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a 15-second delay before the first long-interval Statsbeat export and updates tests to verify initial delay, regular scheduling, and re-enable/disable behavior.
- Introduces
_longHandleTimeoutand schedules the firsttrackLongIntervalStatsbeatsafter 15 seconds. - Updates
enable()/disable()logic to manage both timeout and interval handles. - Adds unit tests covering initial delay, regular intervals, multiple enable calls, and disable-before-delay.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/AutoCollection/Statsbeat.tests.ts | New tests for initial delay, repeated enables, and disable behavior for long-interval Statsbeat |
| AutoCollection/Statsbeat.ts | Added _longHandleTimeout, initialized it, and updated enable()/disable() logic |
lzchen
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 15 Second Delay Timer to Exporting Long Interval Statsbeat