Gradle 9 prereq: convert jar smoke tests to war#4615
Closed
Conversation
trask
force-pushed
the
gradle9-prereq-spring
branch
4 times, most recently
from
841c6d9 to
5250657
Compare
trask
force-pushed
the
gradle9-prereq-spring
branch
from
5250657 to
6b6d1d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to Gradle 9.3.1 forces an upgrade of Spring Boot Gradle plugin from 2.5.12 to 3.4.2 (Spring Boot 2.7.x uses deprecated Gradle APIs removed in Gradle 9). Spring Boot 3.x compiles its
bootJarlauncher classes for Java 17+, making it impossible to run these JARs on Java 8. This breaks all smoke tests using theai.smoke-test-jarconvention withJAVA_8environments.This PR switches most of the smoke tests over from jar to war where we don't have this problem.
Will send another PR to deal with the remaining jar tests in a different way.