Add OTEL Logs SDK #2671

rads-1996 · 2025-11-24T21:08:38Z

No description provided.

Copilot

Pull request overview

This PR adds a comprehensive OpenTelemetry Logs SDK implementation to the shared OpenTelemetry module, enabling structured logging capabilities with trace context integration and configurable log record processing.

Key Changes:

Implements core logs SDK components including LoggerProvider, Logger, and LogRecordImpl
Adds multi-processor architecture for flexible log record handling
Provides configuration management with environment variable support and limits configuration
Includes comprehensive test coverage for all major components

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
shared/OpenTelemetry/src/sdk/config.ts	Configuration loading and environment variable parsing for log record limits
shared/OpenTelemetry/src/sdk/IOTelMultiLogRecordProcessor.ts	Multi-processor implementation for forwarding log records to multiple processors
shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts	Logger provider implementation managing logger instances and lifecycle
shared/OpenTelemetry/src/sdk/IOTelLogger.ts	Logger implementation for emitting log records with trace context
shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts	Log record implementation with attribute management and truncation
shared/OpenTelemetry/src/internal/loggerProviderSharedState.ts	Shared state management for logger provider and processors
shared/OpenTelemetry/src/internal/commonUtils.ts	Added timeout utilities for handling async operations with timeouts
shared/OpenTelemetry/src/internal/attributeHelpers.ts	Improved attribute validation logic for better type checking
shared/OpenTelemetry/src/interfaces/logs/IOTelNoopLogRecordProcessor.ts	No-op processor implementation for default behavior
shared/OpenTelemetry/src/api/noop/noopLogger.ts	No-op logger implementation for post-shutdown scenarios
shared/OpenTelemetry/Tests/Unit/src/sdk/*.Tests.ts	Comprehensive test suites for all SDK components
shared/OpenTelemetry/Tests/Unit/src/index.tests.ts	Test registration for new log SDK test suites

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

shared/OpenTelemetry/src/sdk/IOTelMultiLogRecordProcessor.ts

shared/OpenTelemetry/src/sdk/config.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…sights-JS into otel-sdk

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 11 comments.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

shared/OpenTelemetry/src/sdk/config.ts

shared/OpenTelemetry/src/interfaces/logs/IOTelNoopLogRecordProcessor.ts

shared/OpenTelemetry/src/sdk/config.ts

shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

shared/OpenTelemetry/src/sdk/config.ts

shared/OpenTelemetry/src/internal/commonUtils.ts

shared/OpenTelemetry/src/sdk/config.ts

…cessor.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…sights-JS into otel-sdk

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 11 comments.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

shared/OpenTelemetry/src/sdk/IOTelLoggerProvider.ts

shared/OpenTelemetry/src/sdk/config.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

shared/OpenTelemetry/src/sdk/config.ts

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

MSNev

Should not have ANY classes and interfaces IXXXXXX need to be defined as interfaces

rads-1996 · 2025-11-26T20:19:26Z

@MSNev I am working on changing the console.warn to handleWarn, meanwhile can you please review and let me know if the structure for the interfaces and factory functions look correct?

shared/OpenTelemetry/src/api/noop/noopLogRecordProcessor.ts

shared/OpenTelemetry/src/internal/LoggerProviderSharedState.ts

shared/OpenTelemetry/src/internal/attributeHelpers.ts

shared/OpenTelemetry/src/internal/commonUtils.ts

shared/OpenTelemetry/src/sdk/OTelLogRecord.ts

MSNev · 2025-11-26T20:43:40Z

@MSNev I am working on changing the console.warn to handleWarn, meanwhile can you please review and let me know if the structure for the interfaces and factory functions look correct?

Yes, leaving a few more comments (mostly around bundle sizes etc)

rads-1996 · 2025-12-08T18:59:58Z

@MSNev Could you please take a look again at the changes when you get a moment? Thanks!

MSNev · 2025-12-08T19:55:00Z

shared/OpenTelemetry/src/sdk/OTelLogRecord.ts

+        context
+    } = logRecord;
+
+    const logAttributes = attributes || {};


Consider using an AttributeContainer for handling the attributes as there looks like there might be a bunch of duplicated code and the container is designed to handle inheritance in a clean manner.

This can be a followup PR, just create a task for it so we come back to it.

MSNev · 2025-12-08T19:55:50Z

shared/OpenTelemetry/src/sdk/OTelLogRecord.ts

+            return value;
+        }
+
+        if (typeof value === "string") {


Several cases here where we could use the helpers (that get minified better) isString, isFunction, isArray, isUndefined etc.

Again, this can also be done as a follow up PR. We probably have a single task to search the entire code base for typeof and globals like Array.isArray etc.

MSNev · 2025-12-08T19:59:52Z

shared/OpenTelemetry/src/sdk/OTelLogger.ts

+         * the LogRecords it emits MUST automatically include the Trace Context from the active Context,
+         * if Context has not been explicitly set.
+         */
+        const logRecordData: IOTelLogRecord = {


Just a general FYI.

In some frameworks (not common for browsers / node), declaring a const object will also freeze the instance which then throws exceptions if someone trys to "update" (assign) one of the properties or add additional properties. So if this is possible in the usage of this object it "should" be defined as let rather than const

MSNev · 2025-12-08T20:02:39Z

shared/OpenTelemetry/src/sdk/config.ts

+    const envLogValueLength = getNumberFromEnv("OTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMIT");
+    const envGeneralValueLength = getNumberFromEnv("OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT");
+
+    return {


All config in the web sdk should be dynamic, reassigning an object may not work as expected for this (depending on how the config is defined). This should "probably" be passed the config that it wants to update rather than returning a new object.

MSNev

Left some feedback that can be addressed later.

* Add OTEL Logs SDK * Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix typing, formatting, library issues * Update shared/OpenTelemetry/src/interfaces/logs/IOTelNoopLogRecordProcessor.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixed promise return type * Fix tests * Changes classes structure and used Ixxx only for interfaces * Addressed feedback * Remove extra line * Keep interfaces separate * Remove duplicate file --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add OTEL Logs SDK

fac4d28

rads-1996 requested a review from a team as a code owner November 24, 2025 21:08

Copilot AI review requested due to automatic review settings November 24, 2025 21:08

Copilot started reviewing on behalf of rads-1996 November 24, 2025 21:09 View session

rads-1996 marked this pull request as draft November 24, 2025 21:09

Copilot finished reviewing on behalf of rads-1996 November 24, 2025 21:12

Copilot AI reviewed Nov 24, 2025

View reviewed changes

rads-1996 and others added 3 commits November 24, 2025 13:16

Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

171b731

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix typing, formatting, library issues

8fb9796

Merge branch 'otel-sdk' of https://github.com/rads-1996/ApplicationIn…

3c969bf

…sights-JS into otel-sdk

rads-1996 requested a review from Copilot November 24, 2025 22:25

Copilot started reviewing on behalf of rads-1996 November 24, 2025 22:25 View session

Copilot finished reviewing on behalf of rads-1996 November 24, 2025 22:30

Copilot AI reviewed Nov 24, 2025

View reviewed changes

rads-1996 and others added 5 commits November 24, 2025 14:36

Update shared/OpenTelemetry/src/interfaces/logs/IOTelNoopLogRecordPro…

ea6d2be

…cessor.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

e0978a0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts

54f6dcf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fixed promise return type

b06b8c4

Merge branch 'otel-sdk' of https://github.com/rads-1996/ApplicationIn…

9b3b773

…sights-JS into otel-sdk

rads-1996 requested a review from Copilot November 25, 2025 00:17

Copilot started reviewing on behalf of rads-1996 November 25, 2025 00:18 View session

Copilot finished reviewing on behalf of rads-1996 November 25, 2025 00:19

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Fix tests

a49958c

rads-1996 marked this pull request as ready for review November 25, 2025 18:20

rads-1996 commented Nov 25, 2025

View reviewed changes

shared/OpenTelemetry/src/sdk/config.ts Outdated Show resolved Hide resolved

MSNev reviewed Nov 25, 2025

View reviewed changes

shared/OpenTelemetry/src/sdk/IOTelLogRecordImpl.ts Outdated Show resolved Hide resolved

MSNev requested changes Nov 25, 2025

View reviewed changes

Changes classes structure and used Ixxx only for interfaces

e67a47c

MSNev reviewed Nov 26, 2025

View reviewed changes

shared/OpenTelemetry/src/api/noop/noopLogRecordProcessor.ts Outdated Show resolved Hide resolved

MSNev reviewed Nov 26, 2025

View reviewed changes

shared/OpenTelemetry/src/internal/LoggerProviderSharedState.ts Outdated Show resolved Hide resolved

MSNev reviewed Nov 26, 2025

View reviewed changes

shared/OpenTelemetry/src/internal/attributeHelpers.ts Outdated Show resolved Hide resolved

MSNev reviewed Nov 26, 2025

View reviewed changes

shared/OpenTelemetry/src/internal/commonUtils.ts Show resolved Hide resolved

MSNev reviewed Nov 26, 2025

View reviewed changes

shared/OpenTelemetry/src/sdk/OTelLogRecord.ts Show resolved Hide resolved

MSNev self-requested a review November 26, 2025 20:44

rads-1996 added 4 commits December 1, 2025 08:39

Addressed feedback

689718f

Remove extra line

9bcd04a

Keep interfaces separate

ace8938

Remove duplicate file

49f3018

MSNev reviewed Dec 8, 2025

View reviewed changes

MSNev approved these changes Dec 8, 2025

View reviewed changes

rads-1996 merged commit 6613ec9 into microsoft:otel-sdk Dec 8, 2025
8 checks passed

Add OTEL Logs SDK #2671

Add OTEL Logs SDK #2671

Uh oh!

Conversation

rads-1996 commented Nov 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MSNev left a comment

Choose a reason for hiding this comment

Uh oh!

rads-1996 commented Nov 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MSNev commented Nov 26, 2025

Uh oh!

rads-1996 commented Dec 8, 2025

Uh oh!

MSNev Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

MSNev Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MSNev Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

MSNev Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

MSNev left a comment

Choose a reason for hiding this comment

MSNev Dec 8, 2025 •

edited

Loading