Skip to content

Correct Cleanup of IsolatedStorage on Deletion of SMTP Account #29566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesperSchulz merged 1 commit into from
Jan 12, 2026
+11 −2
Merged

Correct Cleanup of IsolatedStorage on Deletion of SMTP Account #29566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Apps/W1/Email - SMTP Connector/app/src/SMTPAccount.table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ table 4511 "SMTP Account"

trigger OnDelete()
begin
if not IsNullGuid(Rec."Password Key") then
if IsolatedStorage.Delete(Rec."Password Key") then;
DeleteIsolatedStorageIfExists(Rec."Password Key");
DeleteIsolatedStorageIfExists(Rec."Client Id Storage Id");
DeleteIsolatedStorageIfExists(Rec."Client Secret Storage Id");
end;

[NonDebuggable]
Expand Down Expand Up @@ -213,4 +214,12 @@ table 4511 "SMTP Account"
if not IsolatedStorage.Get(Format(ClientSecretKey), DataScope::Company, ClientSecret) then
Error(UnableToGetClientSecretMsg);
end;

local procedure DeleteIsolatedStorageIfExists(KeyToCheck: Guid)
begin
if IsNullGuid(KeyToCheck) then
exit;
if IsolatedStorage.Contains(Format(KeyToCheck), DataScope::Company) then
IsolatedStorage.Delete(Format(KeyToCheck), DataScope::Company);
end;
}
Loading