SL Cloud Migration Update November 2025 #29477

blauerPCL · 2025-12-01T00:45:43Z

Summary

SL Cloud Migration Update for November 2025

New US extension that includes migration of IRS 1099 information
Update for GL Account Beginning Balances
Update to only migrate open AP and AR amounts from released and posted documents
Update for blank SL subaccount segments
Update for dimension shortcuts in General Ledger Setup

This PR replaces closed PRs 29378 and 29394.

Work Item(s)

Fixes #
AB#575741
AB#609658
AB#612598

…ForFieldUpdate to a public procedure

…ns, and remove obsolete codeunit

github-actions · 2025-12-01T00:46:02Z

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

blauerPCL · 2025-12-02T04:31:42Z

@nikolakukrika This PR is now ready for code review. Thank you.

…te for assigning dimensions on Beginning Balance journal entries.

…nto SLMigrationUpdate2025-11

…r, and SL Batch tables to support tests.

nikolakukrika · 2026-01-10T19:40:58Z

Apps/US/HybridSL_US/app/src/Codeunits/SLCloudMigrationUS.Codeunit.al

+        SLPopulateVendor1099Data: Codeunit "SL Populate Vendor 1099 Data";
+    begin
+        if (SLCompanyAdditionalSettings.GetMigrateCurrent1099YearEnabled()) or (SLCompanyAdditionalSettings.GetMigrateNext1099YearEnabled()) then begin
+            SetupIRSFormsFeatureIfNeeded();


GP Migration has this method EnsureSupportedReportingYear.
Do we need to do additional checks?

nikolakukrika · 2026-01-10T19:41:54Z

Apps/US/HybridSL_US/app/src/Codeunits/SLCloudMigrationUS.Codeunit.al

+            SLPopulateVendor1099Data.Run();
+            UnbindSubscription(SLPopulateVendor1099Data);
+        end;
+    end;


GP Migration has SetPreferredVendorBankAccountsUseForElectronicPayments();
Do we need this method too?

nikolakukrika · 2026-01-10T19:44:29Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        SLVendor1099MappingHelpers.InsertSupportedTaxYear(TaxYear);
+
+        // MISC
+        SLVendor1099MappingHelpers.InsertMapping(TaxYear, '1', '1M', 'MISC', 'MISC-01');


We have obsoleted the old IRS1099 functionality. Are you sure that this is the correct implementation?
The GP code looks different

nikolakukrika · 2026-01-10T19:51:01Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        IRS1099Code: Code[10];
+        TaxAmount: Decimal;
+    begin
+        if SLAPBalances.Get(VendorNo, CompanyName) then begin


This level of nesting is too much. The better is
if SLAPBalances.Get(VendorNo, CompanyName) then
exit;

nikolakukrika · 2026-01-10T19:55:12Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+                    VendorYear1099AmountDictionary.Add(IRS1099Code, SLAPBalances.CYBox13);
+            if SLAPBalances.CYBox12 > 0 then
+                IRS1099Code := SLVendor1099MappingHelpers.GetIRS1099BoxCode(TaxYear, '25')
+            else


All of these can be refactored to:

if SLAPBalances.CYBox12 > 0 then begin
IRS1099Code := SLVendor1099MappingHelpers.GetIRS1099BoxCode(TaxYear, '25')
if IRS1099Code <> '' then
if VendorYear1099AmountDictionary.Get(IRS1099Code, TaxAmount) then
VendorYear1099AmountDictionary.Set(IRS1099Code, TaxAmount + SLAPBalances.CYBox12)
else
VendorYear1099AmountDictionary.Add(IRS1099Code, SLAPBalances.CYBox12);
end;

It is more readable and less dependencies on clearing the code

nikolakukrika · 2026-01-10T20:02:48Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        GenJournalBatch.SetRange(Name, GeneralJournalBatchCode);
+        GenJournalBatch.SetRange("No. Series", NoSeriesCode);
+        GenJournalBatch.SetRange("Posting No. Series", PostingNoSeriesCode);
+        if not GenJournalBatch.FindFirst() then begin


if GenJournalBatch.IsEmpty() then begin

We are not using the value anywhere

nikolakukrika · 2026-01-10T20:06:46Z

Apps/US/HybridSL_US/test/src/SLMigrationVendor1099Tests.Codeunit.al

+    begin
+        // [Given] SL Data
+        Initialize();
+        SLTestHelperFunctions.ClearBCVendorTableData();


These three lines should be a part of the initialize method

nikolakukrika · 2026-01-10T20:08:12Z

Apps/US/HybridSL_US/test/src/SLMigrationVendor1099Tests.Codeunit.al

+        TempVendor.FindSet();
+        repeat
+            Assert.IsTrue(Vendor.Get(TempVendor."No."), 'Vendor record not found for No. ' + TempVendor."No.");
+            Assert.AreEqual(TempVendor."Federal ID No.", Vendor."Federal ID No.", 'Federal ID No. does not match for Vendor No. ' + TempVendor."No.");


The migration code is moving more, balances, payment entries. Should we check these as well?
We should get asserts for all things we are migrating

nikolakukrika · 2026-01-10T20:13:04Z

Apps/W1/HybridSL/app/src/Migration/Accounts/SLAccountMigrator.Codeunit.al

+        CreateOpeningBalanceTrx(Sender, RecordIdToMigrate);
+    end;
+
+    internal procedure CreateOpeningBalanceTrx(var Sender: Codeunit "GL Acc. Data Migration Facade"; RecordIdToMigrate: RecordId)


Should we add tests for these?

nikolakukrika · 2026-01-10T20:18:38Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        IRS1099VendorFormBoxSetup: Record "IRS 1099 Vendor Form Box Setup";
+    begin
+        SLCompanyAdditionalSettings.GetSingleInstance();
+        if IRS1099VendorFormBoxSetup.Get(TaxYear, Vendor."No.") then


exit(false) is missing at the bottom.
It is better to refactor to exit(IRS1099VendorFormBoxSetup.Get(TaxYear, Vendor."No."));

nikolakukrika · 2026-01-10T20:19:41Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+                if GLAccount.Get(VendorPostingGroup."Payables Account") then
+                    exit(GLAccount."No.");
+
+        exit('');


Should this be blank or DefaultPayablesAccountCode?
If it should be blank can we get a comment explaining why?

nikolakukrika · 2026-01-10T20:21:53Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+
+        CreateMappingsIfNeeded();
+
+        Evaluate(Day31, Day31Txt);


It is simpler to use PostingDate := DMY2Date(31, 12, CurrentYear);

nikolakukrika · 2026-01-10T20:23:40Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        CurrentYearJournalBatchName := VendorTaxBatchNameTxt + Format(SLCurr1099Yr);
+        GenJournalLine.SetRange("Journal Batch Name", CurrentYearJournalBatchName);
+        GenJournalLine.SetFilter("Account No.", '<>%1', '');
+        if (not GenJournalLine.IsEmpty()) then


Is this the correct logic? If we do not have a current year but we have a next year, we will exit and not clean the next year.
Do all the exits in this method make sense?

nikolakukrika · 2026-01-10T20:25:05Z

Apps/US/HybridSL_US/app/src/PageExt/SLMigrationConfigurationExt.PageExt.al

+        }
+    }
+}
+


Multiple blank lines

nikolakukrika · 2026-01-10T20:33:03Z

Apps/US/HybridSL_US/app/src/Tables/SL1099MigrationLog.Table.al

+            ErrorMessageInStream.ReadText(ErrorMessageLine);
+            ErrorMessageBuilder.AppendLine(ErrorMessageLine);
+        end;
+        exit(ErrorMessageBuilder.ToText().Trim())


Nit - missing terminating ; on the line

nikolakukrika · 2026-01-10T20:36:04Z

Apps/US/HybridSL_US/app/src/Codeunits/SLPopulateVendor1099Data.Codeunit.al

+        SLCompanyAdditionalSettings: Record "SL Company Additional Settings";
+        IRS1099VendorFormBoxSetup: Record "IRS 1099 Vendor Form Box Setup";
+    begin
+        SLCompanyAdditionalSettings.GetSingleInstance();


SLCompanyAdditionalSettings are not used after this line. Is it a bug or should the reference be removed?

blauerPCL and others added 5 commits November 20, 2025 12:38

Add SL 1099 Migration functionality and related data structures

2a72f94

Merge branch 'microsoft:main' into SLMigrationUpdate2025-11

74921fd

Increase CpnyID field length to 30 characters and change PrepSettings…

69d183a

…ForFieldUpdate to a public procedure

Refactor SL 1099 Migration components: rename pages, update permissio…

9bd04cf

…ns, and remove obsolete codeunit

Add Vendor 1099 tests for the Dynamics SL Migration - US extension

b3ff781

JesperSchulz added the Integration GitHub request for Integration area label Dec 1, 2025

blauerPCL added 2 commits December 1, 2025 11:36

GL Account Beginning Balance update and improve dimension handling.

1c0ff54

Only migrate open AP and AR balances for released and posted batches.

8be45fb

This was referenced Dec 2, 2025

Implement migration of Dynamics SL Vendor 1099 data #29378

Closed

SL Migration Account Beginning Balance Update #29394

Closed

blauerPCL changed the title ~~[DRAFT] SL Cloud Migration Update November 2025~~ SL Cloud Migration Update November 2025 Dec 2, 2025

blauerPCL marked this pull request as ready for review December 2, 2025 04:30

blauerPCL requested a review from a team as a code owner December 2, 2025 04:30

blauerPCL requested a review from dcenic December 2, 2025 04:30

blauerPCL and others added 4 commits December 11, 2025 10:52

Merge branch 'microsoft:main' into SLMigrationUpdate2025-11

1e58089

Increase CpnyID field length to 30 to support automated testing. Upda…

94e4545

…te for assigning dimensions on Beginning Balance journal entries.

Merge branch 'main' of https://github.com/blauerPCL/ALAppExtensions i…

b31947b

…nto SLMigrationUpdate2025-11

Increase CpnyID field length to 30 in SL APDoc Buffer, SL ARDoc Buffe…

5544cf6

…r, and SL Batch tables to support tests.

nikolakukrika reviewed Jan 10, 2026

View reviewed changes

nikolakukrika approved these changes Jan 10, 2026

View reviewed changes

nikolakukrika reviewed Jan 10, 2026

View reviewed changes

Apps/US/HybridSL_US/app/src/PageExt/SLMigrationConfigurationExt.PageExt.al

}

}

}

Copy link

Contributor

nikolakukrika Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple blank lines

nikolakukrika reviewed Jan 10, 2026

View reviewed changes

SL Cloud Migration Update November 2025 #29477

Are you sure you want to change the base?

SL Cloud Migration Update November 2025 #29477

Uh oh!

Conversation

blauerPCL commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Work Item(s)

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

blauerPCL commented Dec 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolakukrika Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolakukrika Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blauerPCL commented Dec 1, 2025 •

edited

Loading

nikolakukrika Jan 10, 2026 •

edited

Loading

nikolakukrika Jan 10, 2026 •

edited

Loading