Added purchasers & return reasons to existing purchase documents

[tuan-nguyen-fenwick]

Change log:

• Added Create Return Reason codeunit
• Updated the commission of purchasers BC and RB.
• Purchasing Module: Added purchasers & return reasons to existing purchase documents.
• Analytics Module: Added purchasers & return reasons to existing purchase documents.

Fixes #29344
Fixes AB#599397

[github-actions]

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

[JesperSchulz]

I'm getting build errors:

App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(83,15): error AS0026: The type or subtype of 'ReturnReasonCode' has been modified from 'Decimal' to 'Code[20]'. This is not allowed in events and external procedures because it will break dependent extensions.
App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(88,15): error AS0024: The number of parameters in the external procedure 'InsertPurchaseLineWithItem' has changed from '6' to '7'. This will break dependent extensions.

[tuan-nguyen-fenwick]

I'm getting build errors:

App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(83,15): error AS0026: The type or subtype of 'ReturnReasonCode' has been modified from 'Decimal' to 'Code[20]'. This is not allowed in events and external procedures because it will break dependent extensions.
App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(88,15): error AS0024: The number of parameters in the external procedure 'InsertPurchaseLineWithItem' has changed from '6' to '7'. This will break dependent extensions.

@JesperSchulz Thank you, I've addressed these errors.

[JesperSchulz]

I'm getting build errors:

App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(83,15): error AS0026: The type or subtype of 'ReturnReasonCode' has been modified from 'Decimal' to 'Code[20]'. This is not allowed in events and external procedures because it will break dependent extensions.
App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(88,15): error AS0024: The number of parameters in the external procedure 'InsertPurchaseLineWithItem' has changed from '6' to '7'. This will break dependent extensions.

@JesperSchulz Thank you, I've addressed these errors.

I've pushed your latest changes, but I get the exact same errors from the build system 😔

[tuan-nguyen-fenwick]

I'm getting build errors:

App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(83,15): error AS0026: The type or subtype of 'ReturnReasonCode' has been modified from 'Decimal' to 'Code[20]'. This is not allowed in events and external procedures because it will break dependent extensions.
App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoTool\Contoso Helpers\ContosoPurchase.Codeunit.al(88,15): error AS0024: The number of parameters in the external procedure 'InsertPurchaseLineWithItem' has changed from '6' to '7'. This will break dependent extensions.

@JesperSchulz Thank you, I've addressed these errors.

I've pushed your latest changes, but I get the exact same errors from the build system 😔

@JesperSchulz
Could you advise whether I need to push any further changes?

The error pointed to this breaking change that I fixed in this commit already: 4f2f38d

[JesperSchulz]

599397

Not entirely sure what's going on. Let me start by changing the ReturnReasonCode to length 10 rather than 20. That's not what it's complaining about, but its a mistake nonetheless and it will retrigger a new run.

[JesperSchulz]

OK, now I got past those build errors.

Unfortunately I'm now running into similar local database build issues as in #29347 :-(
I'm not sure what's going on there, but we'll need the SCM team to investigate. Pinging @PredragMaricic.

Here the message:

[2025-12-16 12:41:34] Run-ContosoDemoTool -ServerInstance NAV_CZ -lcid 1029 -CompanyName  CRONUS CZ -CountryCode CZ -Translated
[2025-12-16 12:41:34] Initialize CRONUS CZ. Language ID 1029
Invoking codeunit '2' on tenant '' on server 'NAV_CZ'.
[2025-12-16 12:41:43] Run and generate full Contoso demo data.
Invoking codeunit '5193' on tenant '' on server 'NAV_CZ'.
[2025-12-16 12:44:08] Inner exception:
[2025-12-16 12:44:08] Invoke-jobNAVCodeunit: Je třeba zadat číslo dokladu z dokladu od dodavatele v poli Číslo dobropisu dodavatele tak, aby tento doklad zůstal
--------------------- propojen s originálem.  CorrelationId:  6309ebe9-1a4d-4507-b64e-896f2ac90b83. Status: 400 (Je tA?eba zadat \u010dA­slo
--------------------- dokladu z dokladu od dodavatele v poli \u010cA­slo dobropisu dodavatele tak, aby tento doklad zA─stal propojen s
--------------------- originA!lem.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Je t\u0159eba zadat \u010d\u00edslo dokladu z dokladu od
--------------------- dodavatele v poli \u010c\u00edslo dobropisu dodavatele tak, aby tento doklad z\u016fstal propojen s origin\u00e1lem. 
--------------------- CorrelationId:  6309ebe9-1a4d-4507-b64e-896f2ac90b83."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- 6309ebe9-1a4d-4507-b64e-896f2ac90b83 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAABOR565yfXSvwAAAAA= Date: Tue, 16
--------------------- Dec 2025 11:43:56 GMT Content-Type: application/json Content-Length: 289
--------------------- 

That roughly translates into: You must enter the document number from the vendor document in the Vendor Credit Note Number field so that this document remains

[tuan-nguyen-fenwick]

@JesperSchulz Great catch, I will also investigate this build error and push new update for ReturnReasonCode Text[10].

[tuan-nguyen-fenwick]

@JesperSchulz Great catch, I will also investigate this build error and push new update for ReturnReasonCode Text[10].

@JesperSchulz @attilatoury

1. New commits: I've resolved the Return Reason Code Text[10] issue and some merge conflicts.
2. Build error: I was testing the app in a CZ build: 28.0.44467.0 for this build error

You must enter the document number from the vendor document in the Vendor Credit Note Number field so that this document remains

but CZ is giving me another error which seems irrelevant to my PR changes.

Error message: 
VAT Period does not exist for date 01/01/23.

Internal session ID: 
9f531b3e-c511-4e7d-8582-bb639ce6a3f3

Application Insights session ID: 
cbb3a21e-8278-48c7-b1c9-8059b28b2572

Client activity id: 
3a277451-6100-9304-5124-46798e64eae0

Time stamp on error: 
2026-01-07T08:02:17.6607055Z

User telemetry id: 
0f294648-224f-4c7e-addd-85478b72f0c4

AL call stack: 
"VAT Date Handler CZL"(CodeUnit 11742).VATPeriodCZLCheck line 11 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"VAT Date Handler CZL"(CodeUnit 11742).CheckVATDateCZL line 12 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"Purchase Posting Handler CZL"(CodeUnit 31039).CheckVatDateOnAfterCheckPurchDoc line 4 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).OnAfterCheckPurchDoc(Event) line 2 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).CheckPurchDocument line 78 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).CheckAndUpdate line 9 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).RunWithCheck line 54 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).OnRun(Trigger) line 2 - Base Application by Microsoft version 28.0.44120.0
"Create Posted Purchase Data"(CodeUnit 5689).OnRun(Trigger) line 11 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Purchase Module"(CodeUnit 5394).CreateHistoricalData line 2 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).GenerateDemoData line 29 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).BuildDependencyAndGenerateDemoData line 20 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).CreateDemoData line 16 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(Page 5194)."Generate - OnAction"(Trigger) line 7 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1

Upon investigation, I found the purchase document dates in this codeunit are in 2023. My understanding is the CZ Localization app only creates VAT Periods records for 2 years from today's date which is from 2024 up until now.

And this error didn't come up before the Christmas break because it was still 2025 and would have created VAT Period entries 2 years from 2025, so the app still created VAT Period for 2023.

Can you test if you are getting the same issue in CZ?

[JesperSchulz]

@JesperSchulz Great catch, I will also investigate this build error and push new update for ReturnReasonCode Text[10].

@JesperSchulz @attilatoury

1. New commits: I've resolved the Return Reason Code Text[10] issue and some merge conflicts.
2. Build error: I was testing the app in a CZ build: 28.0.44467.0 for this build error

You must enter the document number from the vendor document in the Vendor Credit Note Number field so that this document remains

but CZ is giving me another error which seems irrelevant to my PR changes.

Error message: 
VAT Period does not exist for date 01/01/23.

Internal session ID: 
9f531b3e-c511-4e7d-8582-bb639ce6a3f3

Application Insights session ID: 
cbb3a21e-8278-48c7-b1c9-8059b28b2572

Client activity id: 
3a277451-6100-9304-5124-46798e64eae0

Time stamp on error: 
2026-01-07T08:02:17.6607055Z

User telemetry id: 
0f294648-224f-4c7e-addd-85478b72f0c4

AL call stack: 
"VAT Date Handler CZL"(CodeUnit 11742).VATPeriodCZLCheck line 11 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"VAT Date Handler CZL"(CodeUnit 11742).CheckVATDateCZL line 12 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"Purchase Posting Handler CZL"(CodeUnit 31039).CheckVatDateOnAfterCheckPurchDoc line 4 - Core Localization Pack for Czech by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).OnAfterCheckPurchDoc(Event) line 2 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).CheckPurchDocument line 78 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).CheckAndUpdate line 9 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).RunWithCheck line 54 - Base Application by Microsoft version 28.0.44120.0
"Purch.-Post"(CodeUnit 90).OnRun(Trigger) line 2 - Base Application by Microsoft version 28.0.44120.0
"Create Posted Purchase Data"(CodeUnit 5689).OnRun(Trigger) line 11 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Purchase Module"(CodeUnit 5394).CreateHistoricalData line 2 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).GenerateDemoData line 29 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).BuildDependencyAndGenerateDemoData line 20 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(CodeUnit 5193).CreateDemoData line 16 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1
"Contoso Demo Tool"(Page 5194)."Generate - OnAction"(Trigger) line 7 - Contoso Coffee Demo Dataset by Microsoft version 28.0.44120.1

Upon investigation, I found the purchase document dates in this codeunit are in 2023. My understanding is the CZ Localization app only creates VAT Periods records for 2 years from today's date which is from 2024 up until now.

And this error didn't come up before the Christmas break because it was still 2025 and would have created VAT Period entries 2 years from 2025, so the app still created VAT Period for 2023.

Can you test if you are getting the same issue in CZ?

Sure can! Stay tuned :-)

[JesperSchulz]

Looks like we've got a ton of merge issues :-( Other changes were made to the same objects to address a different issue.

Let me sync the repos. Maybe it just looks bad, but is easy to merge? I'll do a sync right away.