refactor: extract validation and waitFor parsing helpers#358
Open
Syedowais312 wants to merge 1 commit into
Open
refactor: extract validation and waitFor parsing helpers#358Syedowais312 wants to merge 1 commit into
Syedowais312 wants to merge 1 commit into
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
Signed-off-by: syedowais312 <syedowais312sf@gmail.com>
4edfcfd to
1c77897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
testcommand implementation by extracting:--waitForparsing logicinto reusable helper functions.
Changes
validateTestCommandArgs()parseWaitForMilliseconds()parseWaitForValue()testResultIDBenefits