Conversation
This lets us modify `Block.write()` more freely.
Show integers corresponding to the row and column indexes of diagrams.
For example,
0 5 9
| | |
0 - **********
*........|
*...-----+
*..|#?????
*..|??????
5 - *..|??????
6 - *--+??????
Contributor
|
It is an improvement over what is available now. Although still inconvenient to my linking, as requires unix-fu to read wide diagrams, and numbers on current frontier is unreadable and need to be visually constructed from the diagram. For #155 I need only two max numbers and direction of branches to understand what is going on. Numbers in between are not as useful. They may help to understand how much is left to rebase, but a separate status block that can be scripted into |
Contributor
|
@mhagger better merge it. Maybe make it optional if somebody needs to parse the diagram for alternative presentation. But then the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here, add integers along the top and left edges of diagrams showing the column and row indexes corresponding to the diagram entries, and add the names of the two branch tips at the end of the axes:
For the top axis, it can be a little bit awkward to keep the index of the final column from running into the index of the last multiple-of-five column. To solve this, I've:
Right-justified most column indexes, but left-justified the last one.
Added an extra space and change the tick mark into
/if the last column is adjacent to the last multiple-of-five column, like so:Fixes: #155
/cc @abitrolly: What do you think of this alternative?