Don't add 'rebased-with-history from <commit>' if IMERGE_MODIFY_COMMI…#134
Don't add 'rebased-with-history from <commit>' if IMERGE_MODIFY_COMMI…#134brucehoult wants to merge 1 commit intomhagger:masterfrom
Conversation
|
|
||
| def get_modified_log_message(self, orig, kind): | ||
| msg = self.git.get_log_message(orig) | ||
| if os.environ.get('IMERGE_MODIFY_COMMIT_MSG','1') != '0': |
There was a problem hiding this comment.
No point to cache/optimise this as the subsequent git operation is far more heavyweight.
|
I like the idea, but why an environment variable? Wouldn't it be more natural to use a git configuration setting, as we already do for Another question: would it be useful to add the |
|
Ok sure git config would work. Replacing any previous "rebased with history" (etc) line would be a better option than the current default, but I still personally prefer nothing at all. |
2 participants
After running rebase-with-history (which is otherwise great) many times, the commit messages get horrible.
I think it's better to not modify the messages. Enable this to be opted-out of globally by setting an environment variable.
You can see the hashes of all the parents of the commit in the git log for it anyway.