Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect --version output (Issue #63) by ensuring the CLI reports the release tag when built as a PHAR, while still reporting the Composer-installed package version when installed via Composer.
Changes:
- Use a Box-replaced
@package_version@placeholder for PHAR builds, with a ComposerInstalledVersionsfallback for non-PHAR installs. - Configure Box to inject the git-derived version into the build.
- Update the release workflow checkout to fetch full git history (required for tag-based versioning).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Cli/Application.php |
Uses a build-time placeholder for PHAR versioning with a Composer fallback. |
box.json |
Configures Box to provide a git-derived version for placeholder replacement. |
.github/workflows/release.yml |
Ensures tags/history are available during release builds by using fetch-depth: 0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mglaman
commented
Feb 27, 2026
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "git-version": "@package_version@", | |||
Owner
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63