Skip to content

Fix Tracking & 404 Banner #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gantoreno wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −11
Open

Fix Tracking & 404 Banner #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c74f3a1
fix: pull latest chrome
gantoreno May 27, 2026
6af69f6
fix: set build env to production
gantoreno May 27, 2026
441b8dd
fix: use chrome within 404 pages
gantoreno May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions _data/shared_chrome.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions _layouts/error.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
<body>


{% include navigation-header.html highlight=true %}
{% include shared-chrome/header.html %}

<div class="bootstrap">
<div class="container pt-6 pb-9">
{{ content }}
</div>
</div>

{% include footer.html %}
{% include shared-chrome/footer.html %}
</body>
</html>
2 changes: 1 addition & 1 deletion amplify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ frontend:
- bundle _2.5.22_ install
build:
commands:
- bundle _2.5.22_ exec jekyll build
- JEKYLL_ENV=production NODE_ENV=production bundle _2.5.22_ exec jekyll build
artifacts:
baseDirectory: _site
files:
Expand Down