Make sure 404 pages work#1148
Merged
Merged
Conversation
alexyarosh
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRO-461
The behavior we want for 404 pages is to keep whatever the accessed URL is intact (e.g.
/docs/asd) while rendering the contents of 404.htmlThe current Amplify rewrite configuration achieves this partially, but since the target is
/404.html, this ends up landing in the main website's404.html, which is also part of a rewrite. We don't want to stack rewrites over rewrites cross-deployments, this gets into messy behavior territory.This PR moves 404.html to be under
/docs/404.html, so that docs 404 rewrites over the docs-owned404.html.