Skip to content

Fix broken resources menu via shared chrome#1145

Merged
gantoreno merged 2 commits into
masterfrom
gro-469-resources-menu-is-broken-on-docs-staging-site
May 22, 2026
Merged

Fix broken resources menu via shared chrome#1145
gantoreno merged 2 commits into
masterfrom
gro-469-resources-menu-is-broken-on-docs-staging-site

Conversation

@gantoreno

@gantoreno gantoreno commented May 22, 2026

Copy link
Copy Markdown
Contributor

Fixes GRO-469

  • Brings in the shared chrome and introduces it as part of the build step, keeping it in sync with https://metabase.com/shared/chrome.json and removing the need for having local includes to render

@gantoreno gantoreno requested a review from a team May 22, 2026 17:45
iethree
iethree approved these changes May 22, 2026
View reviewed changes

@iethree iethree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gantoreno gantoreno merged commit c47c010 into master May 22, 2026
1 check passed
@gantoreno gantoreno deleted the gro-469-resources-menu-is-broken-on-docs-staging-site branch May 22, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iethree iethree iethree approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gantoreno @iethree