Skip tests that require ffmpeg built with libvpx support also on Win with ffmpeg 8#1016
Skip tests that require ffmpeg built with libvpx support also on Win with ffmpeg 8#1016traversaro wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
|
I forgot to mark this PR not as Draft, but it is ready for review. |
|
Thanks for the PR @traversaro . I'm unsure what to do, it seems like these tests are passing fine in our CI (example run). Looking at the output of Would you be able to print the value of torchcodec/src/torchcodec/_core/Encoder.cpp Line 619 in 169484d |
If I understood correctly, this was solved in #1187 (comment) :
Thanks @NicolasHug ! |
I was obtaining some test failures in conda-forge/torchcodec-feedstock#39, and it seems that some tests required ffmpeg built with libvpx support, to have a vp8 encoder, that is currently not available on Windows due to conda-forge/libvpx-feedstock#6 .
Indeed, it seems that for some reason the related tests were disabled for ffmpeg 6 and 7, while not for ffmpeg 8, even if also ffmpeg 8 on Windows does not have a vp8 encoder. I am not sure why upstream CI is passing, but this patch fixes the tests on conda-forge.