chore(build): Enable and configure Compose Compiler reports #4289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables and configures Compose Compiler metrics and reports to help analyze and debug composition performance. The configuration logic is centralized into a new `configureComposeCompiler` extension function.
### Key Changes:
- **Enable Reports:** Set `enableComposeCompilerMetrics` and `enableComposeCompilerReports` to `true` in `gradle.properties`.
- **Centralized Configuration:**
- A new file, `ComposeCompilerConfiguration.kt`, is introduced, containing an internal `configureComposeCompiler` extension function.
- This function reads the new properties and sets the output directories for metrics and reports relative to each project's build folder.
- It also configures the stability configuration file (`compose_compiler_config.conf`).
- **Build Logic Refactoring:**
- The `AndroidCompose.kt` and `KmpLibraryComposeConventionPlugin.kt` files are updated to call the new `configureComposeCompiler` function, removing duplicated configuration code.
- **Dependency Cleanup:**
- Removed `toolchainVendor=JETBRAINS` from `gradle/gradle-daemon-jvm.properties` as it is redundant.
- Removed an unused `android.lint` plugin from `build-logic/convention/build.gradle.kts`.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables and configures Compose Compiler metrics and reports to help analyze and debug composition performance. The configuration logic is centralized into a new
configureComposeCompilerextension function.Key Changes:
enableComposeCompilerMetricsandenableComposeCompilerReportstotrueingradle.properties.ComposeCompilerConfiguration.kt, is introduced, containing an internalconfigureComposeCompilerextension function.compose_compiler_config.conf).AndroidCompose.ktandKmpLibraryComposeConventionPlugin.ktfiles are updated to call the newconfigureComposeCompilerfunction, removing duplicated configuration code.toolchainVendor=JETBRAINSfromgradle/gradle-daemon-jvm.propertiesas it is redundant.android.lintplugin frombuild-logic/convention/build.gradle.kts.as suggested in #4286 - but done with a bit more care.