Ikoka Handheld compile fix, fix inverted LED, add status LED#1869
Open
andyshinn wants to merge 4 commits intomeshcore-dev:devfrom
Open
Ikoka Handheld compile fix, fix inverted LED, add status LED#1869andyshinn wants to merge 4 commits intomeshcore-dev:devfrom
andyshinn wants to merge 4 commits intomeshcore-dev:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Ikoka Handheld nRF52 variant configuration to restore successful builds on the target hardware and to correct/status-enable onboard LEDs.
Changes:
- Fix Ikoka Handheld PlatformIO environment configuration by specifying the correct board and linker script.
- Correct the active level for onboard LEDs (
LED_STATE_ON) so the BLE/status LED logic matches the hardware wiring. - Add
PIN_STATUS_LEDmapping (green LED) to enable a user/status indicator LED on this device.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
variants/ikoka_handheld_nrf/variant.h |
Fixes LED active state definition and introduces PIN_STATUS_LED for the handheld variant. |
variants/ikoka_handheld_nrf/platformio.ini |
Adds board/ldscript settings and fixes env inheritance to build the correct variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #1695. Fixes compiling on Ikoka Handheld but also fixes the inverted LED state (BLE status LED now works) and adds the green LED as a user status LED.