Open
Conversation
pbaranskimrx
left a comment
pbaranskimrx
left a comment
There was a problem hiding this comment.
Nice 👏 Only a few comments regarding code quality
|
|
||
|
|
||
| @pytest.fixture() | ||
| def active_user_with_twilio_call_otp() -> UserModel: |
There was a problem hiding this comment.
Code inside this function and here: active_user_with_twilio_sms_otp are the same instead of method_name. maybe extracting it to another function will avoid DRY?
testproject/tests/test_backends.py
Outdated
|
|
||
| @pytest.mark.django_db | ||
| def test_twilio_call_backend_without_credentials(active_user_with_twilio_call_otp, settings): | ||
| auth_method = active_user_with_twilio_call_otp.mfa_methods.get(name="call_twilio") |
There was a problem hiding this comment.
What about storing mfa_methods in Enum class?
Codecov Report
@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
+ Coverage 97.72% 97.89% +0.17%
===========================================
Files 40 40
Lines 878 902 +24
===========================================
+ Hits 858 883 +25
+ Misses 20 19 -1
|
pbaranskimrx
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.