[WC-3355]: fix combobox not updating displayed value on external attribute change#2173
Open
rahmanunver wants to merge 1 commit intomainfrom
Open
[WC-3355]: fix combobox not updating displayed value on external attribute change#2173rahmanunver wants to merge 1 commit intomainfrom
rahmanunver wants to merge 1 commit intomainfrom
Conversation
…es externally in database mode Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
368511d to
1b2d1c5
Compare
r0b1n
reviewed
Apr 13, 2026
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <package xmlns="http://www.mendix.com/package/1.0/"> | ||
| <clientModule name="Combobox" version="2.8.0" xmlns="http://www.mendix.com/clientModule/1.0/"> | ||
| <clientModule name="Combobox" version="2.8.1" xmlns="http://www.mendix.com/clientModule/1.0/"> |
Collaborator
There was a problem hiding this comment.
We bump versions in release preparation step nowadays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
In database mode, the combobox displayed a stale value when the target attribute was changed externally (e.g. by a popup combobox writing to the same attribute).
Root cause:
DatabaseSingleSelectionSelector.updateProps()only syncedcurrentIdon initial load (!this.currentId). When the attribute changed from value A to value B whilecurrentIdwas already set to A, the condition was false socurrentIdstayed at A and the display never updated.Fix: Added a second condition — also enter the sync branch when the current option's stored value no longer matches the incoming
targetAttribute.value, using the existing_valuesIsEqualhelper for type-safe comparison. A matching value short-circuits the scan, so there is no performance impact on the common (no-change) case.Files changed:
src/helpers/Database/DatabaseSingleSelectionSelector.ts— core fix (one condition added)CHANGELOG.md—### Fixedentry under## [Unreleased]package.json+src/package.xml— version bump 2.8.0 → 2.8.1AGENTS.md— architecture reference for future debugging sessionsWhat should be covered while testing?