Open
Conversation
reneemeyer
reviewed
May 14, 2018
03week/towersOfHanoi.js
Outdated
| function isLegal() { | ||
| // Your code here | ||
| const isLegal = (startStack, endStack) => { | ||
| if (stacks[startStack][stacks[startStack].length - 1] > stacks[endStack][stacks[endStack].length - 1]) { |
There was a problem hiding this comment.
could be simplified, just return the evaluation
03week/towersOfHanoi.js
Outdated
| function checkForWin() { | ||
| // Your code here | ||
| const checkForWin = () => { | ||
| if (stacks.b[3] == 1 || stacks.c[3] == 1) { |
There was a problem hiding this comment.
could be simplified, just return the evaluation
03week/towersOfHanoi.js
Outdated
| }; | ||
|
|
||
| const legalMove = (startStack, endStack) => { | ||
| if (isLegal(startStack, endStack)) { |
There was a problem hiding this comment.
legalMove should only check if the move it's legal, it's not responsible for calling movePiece
03week/towersOfHanoi.js
Outdated
| // Your code here | ||
| const towersOfHanoi = (startStack, endStack) => { | ||
|
|
||
| legalMove(startStack, endStack); |
There was a problem hiding this comment.
Need to fix your function organization here. If the move is legal THEN you would move the piece and check for a win. If there's not a win you would reset the game. Here you are reseting the game every time
…turning statement evaluation. legalMove and isLegal performing same function.remove legalMove. update towersOfHanoi organization. reset only when checkForWin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3