Skip to content

fix: ViewPropType is depreciated#943

Open
ram33z wants to merge 2 commits intomeliorence:masterfrom
ram33z:master
Open

fix: ViewPropType is depreciated#943
ram33z wants to merge 2 commits intomeliorence:masterfrom
ram33z:master

Conversation

@ram33z
Copy link
Copy Markdown

@ram33z ram33z commented Sep 7, 2022

Platforms affected

What does this PR do?

ViewPropType is depreciated from react-native and is not supported directly. This fix implements deprecated-react-native-prop-types package to import ViewPropType wherever required.

What testing has been done on this change?

Locally, also implemented in react-native app and tested via an expo go platform.

Tested features checklist

@jkester1986
Copy link
Copy Markdown

would love to see this merged, we use this package but ViewPropTypes is no longer supported in the latest version of RN and the deprecated package needs to be used now

@abbasldn
Copy link
Copy Markdown

I've made these changes on my local machine as well. Hoping they merge this PR

@Jeith
Copy link
Copy Markdown

Jeith commented Sep 21, 2022

Hoping to see a merge soon - this is a major problem within our app

@DanielATm
Copy link
Copy Markdown

Changes are working perfectly, so hope soon to get merged.

@Jeith
Copy link
Copy Markdown

Jeith commented Oct 4, 2022

Any chance we'll see this merged @Anthony-Buisson @bd-arc ? These changes are working great on my side. Would love to have these changes in the npm package

@LG1710
Copy link
Copy Markdown

LG1710 commented Jan 13, 2023

Hello, could you merge this PR soon to use in a new tagged version, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants