Open
Conversation
caferyukseloglu
approved these changes
Sep 9, 2022
|
would love to see this merged, we use this package but ViewPropTypes is no longer supported in the latest version of RN and the deprecated package needs to be used now |
|
I've made these changes on my local machine as well. Hoping they merge this PR |
|
Hoping to see a merge soon - this is a major problem within our app |
|
Changes are working perfectly, so hope soon to get merged. |
|
Any chance we'll see this merged @Anthony-Buisson @bd-arc ? These changes are working great on my side. Would love to have these changes in the npm package |
|
Hello, could you merge this PR soon to use in a new tagged version, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
ViewPropType is depreciated from react-native and is not supported directly. This fix implements
deprecated-react-native-prop-typespackage to import ViewPropType wherever required.What testing has been done on this change?
Locally, also implemented in react-native app and tested via an expo go platform.
Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponent