added deprecated-react-native-prop-types to handle ViewPropTypes#1027
Open
Irfanwani wants to merge 1 commit intomeliorence:masterfrom
Open
added deprecated-react-native-prop-types to handle ViewPropTypes#1027Irfanwani wants to merge 1 commit intomeliorence:masterfrom
Irfanwani wants to merge 1 commit intomeliorence:masterfrom
Conversation
dshirazi
approved these changes
Oct 7, 2024
|
Hi! Is there a chance to merge this PR soon, given that it has been approved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android and iOS
What does this PR do?
ViewPropTypeshas been removed from react-native so if still using, we need to usedeprecated-react-native-prop-typesto access the mentioned types. I added the same package to handle the type safety.What testing has been done on this change?
Manual testing, as I am using the same package in one of my projects.
Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponent