fix: improve system theme handling and local development experience (#234)#293
fix: improve system theme handling and local development experience (#234)#293priyanshujoshi99 wants to merge 3 commits intomedyo:developfrom
Conversation
priyanshujoshi99
force-pushed
the
develop
branch
from
1a8855e to
e871eff
Compare
|
We should have a dedicated icon for the system theme option. Currently, switching between light and dark requires clicking the moon icon twice because the intermediate state belongs to system which is confusing. |
Fair observation @medyo, I've pushed some changes now. We'll see the monitor icon for the system-selected theme. |
|
It looks good. However, I’m a bit skeptical about keeping the theme preference button in the header since it’s a one-time setting that users rarely change. What do you think about removing it from the header? |
|
I’ve kept it where it is for now, since existing users are used to seeing it there, and removing it might make it feel like the theme option is no longer available. That said, I’m fine with moving it out of the header and keeping it only on the Settings screen if that works better. Let me know what you think. |
|
@priyanshujoshi99 That’s okay. Theme isn’t really a product feature, and analytics show it’s rarely changed. |
- Removed the theme switcher button and its cycle logic from the Header component. - Deleted the unused `darkfocus` variant from CircleButton and its corresponding styles in Button.css. - Cleaned up unused icon imports and analytics tracking related to header theme switching. - Retained core theme application logic for settings-based changes.
|
@medyo , done ✅ |
2 participants
This PR addresses the request for system-based theme synchronization and improves the local development environment setup.
Closes: #234
Changes
🎨 System Theme Support
Dynamic Theme: The theme now dynamically switches to match the resolved system state (Dark vs. Light).
Live Updates: Added a media query listener so the UI and icons update immediately when the OS theme changes without requiring a refresh.
🛠️ Developer Experience (DX)
Graceful Auth Fallback: Added a mock for Firebase Auth when the API key is missing, allowing developers to run the project locally without full Firebase configuration.
Enhanced Documentation:
README.mdwith the correct Vite dev port (5173).Verification Results
[x] Setup: Verified
yarn startworks with a minimal.envfile.[x] Documentation: Links and commands in README verified against current project structure.