Skip to content

feat: adding support to enable custom delimiter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishalwithme wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: adding support to enable custom delimiter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f187de
feat: adding support to enable custom delimiter
vbhard1 Sep 29, 2021
7e6f064
adding unit tests
vbhard1 Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jsonpath.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ func (d DoesNotExist) Error() string {
var invalidObjError = errors.New("invalid object")
var pathDelimiter = "."

func SetDelimiter(delimiter string) {
if len(delimiter) > 0 {
pathDelimiter = delimiter
}
}

func tokenizePath(path string) ([]string, error) {
var tokens []string
for _, stem := range strings.Split(path, pathDelimiter) {
Expand Down
13 changes: 12 additions & 1 deletion jsonpath_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ var data = map[string]interface{}{
"user": map[string]interface{}{
"firstname": "seth",
"lastname": "rogen",
"address.local": "my temp address",
},
"age": 35,
"filmography": map[string]interface{}{
Expand Down Expand Up @@ -50,6 +51,16 @@ func TestGet(t *testing.T) {
if _, ok:= err.(DoesNotExist); result != nil || !ok {
t.Errorf("does not handle non-existant path correctly")
}

SetDelimiter("|")
result, err = Get(data, "user|address.local")
if err != nil {
t.Errorf("failed to get user|address.local")
}
if result != "my temp address" {
t.Errorf("wrong get value, wanted %v, got %v", "my temp address", result)
}
SetDelimiter(".")
}

func TestSet(t *testing.T) {
Expand Down Expand Up @@ -191,4 +202,4 @@ func TestErrors(t *testing.T) {
if _, ok := err.(DoesNotExist); !ok && err != nil {
t.Errorf("error retrieving value %v", err)
}
}
}