Conversation
Summary of ChangesHello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully adds the tracking_token attribute to the Minfraud::Components::Device object, including necessary updates to the CHANGELOG.md, README.md, lib/minfraud/components/device.rb, and spec/components/device_spec.rb files. The changes are well-implemented and follow the existing code patterns. The new field is properly initialized and validated, and a corresponding unit test has been added. The README.md and CHANGELOG.md have been updated to reflect this new feature, ensuring clear documentation for users.
This adds the optional tracking_token attribute to the Device request object for explicit device linking via the Device Tracking Add-on. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-4048
branch
from
714361c to
f05aa08
Compare
| @accept_language = params[:accept_language] | ||
| @session_age = params[:session_age] | ||
| @session_id = params[:session_id] | ||
| @tracking_token = params[:tracking_token] |
There was a problem hiding this comment.
Not sure if we want to change this given we say it is opaque, but this seems to be the only string we don't have a length check on (see validate below)
There was a problem hiding this comment.
Right, I think I commented on some of the others that I'd prefer to leave the check to be server side so that we have more flexibility to change it without breaking anything (e.g., I experimented with base64 JSON payloads so that we could pass additional data back). We can probably add some more validation in the clients in the future once we are sure we won't be changing it.
CHANGELOG.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| # Changelog | |||
|
|
|||
| ## v2.11.0 | |||
There was a problem hiding this comment.
Should this be in the 2.10.0 section?
2 participants
Summary
tracking_tokenattribute toMinfraud::Components::Devicefor explicit device linking via the Device Tracking Add-onENG-4048
Test plan
🤖 Generated with Claude Code