Use uv-venv-lock-runner to respect uv.lock in tox#319
Conversation
The default uv-venv-runner uses uv pip install which ignores the lock file. Switch to uv-venv-lock-runner so tox environments use uv sync --locked and install the exact versions pinned in uv.lock. See tox-dev/tox-uv#288 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The uv-venv-lock-runner disregards --skip-pkg-install, making the two-step pattern (--notest then --skip-pkg-install) unnecessary. Consolidate into a single tox run step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances dependency consistency within "tox" environments by configuring "tox" to utilize "uv-venv-lock-runner". This change ensures that "tox" environments strictly adhere to the versions pinned in "uv.lock" through "uv sync --locked", preventing the installation of newer, potentially incompatible, dependency versions. Consequently, CI workflows are streamlined, reducing complexity and improving reliability. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the pyproject.toml file to use uv-venv-lock-runner for tox environments, ensuring that dependency versions are pinned according to uv.lock. This change simplifies CI workflows by reducing the number of tox steps. I have added one review comment to address a potential issue.
Summary
uv-venv-runnertouv-venv-lock-runnerso that tox environments useuv sync --lockedand install the exact dependency versions pinned inuv.locktest.ymlandtest-libmaxminddb.yml) from two tox steps to one, since--skip-pkg-installis disregarded by the lock runnerThe default runner uses
uv pip installwhich ignores the lock file entirely, allowing newer dependency versions to be installed than what's locked.See tox-dev/tox-uv#288
Test plan
uv run tox -e lintworks locally🤖 Generated with Claude Code