Plugable bytereader#230
Closed
shawjef3 wants to merge 3 commits intomaxmind:mainfrom
shawjef3:jmh-plugable-bytereader
Closed
Plugable bytereader#230shawjef3 wants to merge 3 commits intomaxmind:mainfrom shawjef3:jmh-plugable-bytereader
shawjef3 wants to merge 3 commits intomaxmind:mainfrom
shawjef3:jmh-plugable-bytereader
Conversation
`bufferHolderReference` can be volatile instead of atomic, since operations like `getAndSet` aren't used.
Member
|
I haven't gone through this PR line by line and I haven't tested it myself, but I am a bit confused about why it would be faster after the change. It appears that we are primarily adding an abstraction layer, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon #228 and is for #229.
before
after