Implement guided generation for OllamaLanguageModel#121
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements guided generation (structured output) support for the OllamaLanguageModel, allowing it to generate responses conforming to Swift types annotated with @Generable, not just plain strings.
Changes:
- Removed the String-only restriction that previously caused a fatal error for structured types
- Added schema conversion and format parameter support to guide Ollama's output generation
- Updated response parsing logic to handle both String and structured JSON responses in both streaming and non-streaming modes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/AnyLanguageModel/Models/OllamaLanguageModel.swift | Implements structured generation by converting GenerationSchema to JSONSchema format, passing it via the format parameter to Ollama API, and parsing JSON responses into structured types |
| Tests/AnyLanguageModelTests/OllamaLanguageModelTests.swift | Adds test struct OllamaStructuredForecast and two tests (structuredResponse and streamingStructured) to verify structured generation works correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #27