Update build tooling from starter template and fix linter issues#964
Open
Update build tooling from starter template and fix linter issues#964
Conversation
- Update Go version from 1.24.6 to 1.24.11
- Update golangci-lint to v2.8.0 with new config format
- Update gotestsum to v1.13.0
- Update Node.js version from 16.13.1 to 20.11
- Add manifest-check target to Makefile
- Use Go 1.24 features (strings.SplitSeq, slices.Contains)
- Replace interface{} with any throughout codebase
- Replace custom contains functions with slices.Contains
- Convert if-else chains to tagged switches
- Simplify embedded field selectors (c.Context.Ctx → c.Ctx)
- Use strings.Builder for efficient string concatenation
- Apply De Morgan's law simplifications
- Fix directory permissions (0755 → 0750)
- Add license headers to build files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nevyangelova
requested changes
Feb 5, 2026
nevyangelova
left a comment
nevyangelova
left a comment
There was a problem hiding this comment.
Thanks @hanzei some minor changes. Also I see tests for contains and SliceContainsString were removed but the tests for containsValue in utils_test.go were also removed. Consider keeping at least one integration test to verify the behavior with your specific use cases.
| // Only send down fields to client that are needed | ||
| type RepositoryResponse struct { | ||
| DefaultRepo RepoResponse `json:"defaultRepo,omitempty"` | ||
| DefaultRepo RepoResponse `json:"defaultRepo"` |
There was a problem hiding this comment.
Is there a reason for removing omitempty? it causes an empty {} to be sent when no default repo is set. The frontend checks if (yourReposByOrg?.defaultRepo) which is truthy for {} causing undefined values to be passed to onChangeForRepo().
|
|
||
| orgs := strings.Split(configuredOrgs, ",") | ||
| for _, org := range orgs { | ||
| for org := range strings.SplitSeq(configuredOrgs, ",") { |
There was a problem hiding this comment.
Those are Go 1.24+ features. we should ensure all CI/CD pipelines and developer environments support them
| @@ -1635,7 +1600,6 @@ func TestHandleSubscribe(t *testing.T) { | |||
| name: "default case, handleSubscribesAdd called", | |||
| parameters: []string{"invalid_parameter_1", "invalid_parameter_2", "invalid_parameter_3"}, | |||
| setup: func() { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make check-styleChanges
Build Tooling
.golangci.ymlto version 2 format with new linters (bidichk, makezero, modernize, unqueryvet)Makefilewith new tool versions and manifest-check targetbuild/setup.mkbuild/manifest/main.goCode Modernization
interface{}withanythroughout codebasecontains/SliceContainsStringfunctions withslices.Containsstrings.SplitSeq,fmt.Appendf)c.Context.Ctx→c.Ctx)strings.Builderfor efficient string concatenation in loopsConfig Files
.nvmrcfrom 16.13.1 to 20.11.editorconfig.gitignoreTest plan
make check-stylepasses with 0 issuesmake testpasses (435 Go tests + 22 webapp tests)🤖 Generated with Claude Code