Fix: Use span instead of div for header drop-down arrows #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the header's drop-down to use
spaninstead ofdivfor its arrows since the latter isn't valid as a child element of alabel. See: https://validator.w3.org/nu/?doc=https%3A%2F%2Fmatrix.orgRelated issues
No related issues, as this is a fairly minor change.
Role
Individual not affiliated with any project relevant to this PR.
Timeline
There’s no immediate deadline, so feel free to review this PR whenever you can.
Signoff
Please sign off your individual commits or whole pull request.