Skip to content

Upload device keys to enable uploading OTKs #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadLittleMods merged 1 commit into from
Dec 19, 2025
Merged

Upload device keys to enable uploading OTKs #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/csapi/upload_keys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,11 @@ func TestKeyClaimOrdering(t *testing.T) {
deployment := complement.Deploy(t, 1)
defer deployment.Destroy(t)
alice := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
_, oneTimeKeys := alice.MustGenerateOneTimeKeys(t, 2)
deviceKeys, oneTimeKeys := alice.MustGenerateOneTimeKeys(t, 2)

// first upload key 1, sleep a bit, then upload key 0.
otk1 := map[string]interface{}{"signed_curve25519:1": oneTimeKeys["signed_curve25519:1"]}
alice.MustUploadKeys(t, nil, otk1)
alice.MustUploadKeys(t, deviceKeys, otk1)
Comment on lines +183 to +187
Copy link
Collaborator

@MadLittleMods MadLittleMods Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only place where we didn't do this. Are we sure this wasn't on purpose (should have had a comment if-so)?

This test is about one-time key claim ordering so it shouldn't matter ⏩

// Ensure that there is a difference in timestamp between the two upload requests.
time.Sleep(1 * time.Second)

Expand Down
Loading